From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pmatouse@redhat.com, jcody@redhat.com,
armbru@redhat.com, stefanha@redhat.com, famz@redhat.com,
asias@redhat.com, areis@redhat.com
Subject: [Qemu-devel] [PATCH v4 02/10] vmdk: Make VMDK3Header and VmdkGrainMarker QEMU_PACKED
Date: Tue, 6 Aug 2013 15:44:47 +0800 [thread overview]
Message-ID: <1375775095-19456-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1375775095-19456-1-git-send-email-famz@redhat.com>
It's best to make it consistent that all on disk structures are
QEMU_PACKED.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/vmdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index f42657b..8b86fe9 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -62,7 +62,7 @@ typedef struct {
uint32_t cylinders;
uint32_t heads;
uint32_t sectors_per_track;
-} VMDK3Header;
+} QEMU_PACKED VMDK3Header;
typedef struct {
uint32_t version;
@@ -131,7 +131,7 @@ typedef struct VmdkGrainMarker {
uint64_t lba;
uint32_t size;
uint8_t data[0];
-} VmdkGrainMarker;
+} QEMU_PACKED VmdkGrainMarker;
enum {
MARKER_END_OF_STREAM = 0,
--
1.8.3.4
next prev parent reply other threads:[~2013-08-06 7:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 7:44 [Qemu-devel] [PATCH v4 00/10] vmdk: Input validation fixes Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 01/10] vmdk: remove ret from inner scope Fam Zheng
2013-08-06 12:15 ` Kevin Wolf
2013-08-06 12:37 ` Jeff Cody
2013-08-06 7:44 ` Fam Zheng [this message]
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 03/10] vmdk: use unsigned values for on disk header fields Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 04/10] qemu-iotests: add poke_file utility function Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 05/10] qemu-iotests: add empty test case for vmdk Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 06/10] vmdk: check granularity field in opening Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 07/10] vmdk: check l2 table size when opening Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 08/10] vmdk: check l1 size before opening image Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 09/10] vmdk: use heap allocation for whole_grain Fam Zheng
2013-08-06 7:44 ` [Qemu-devel] [PATCH v4 10/10] vmdk: rename num_gtes_per_gte to num_gtes_per_gt Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375775095-19456-3-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=areis@redhat.com \
--cc=armbru@redhat.com \
--cc=asias@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pmatouse@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).