From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 05/14] sheepdog: add missing .bdrv_has_zero_init
Date: Tue, 6 Aug 2013 16:39:41 +0200 [thread overview]
Message-ID: <1375799990-995-6-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1375799990-995-1-git-send-email-kwolf@redhat.com>
From: Liu Yuan <namei.unix@gmail.com>
Commit 3ac21627 changed the behaviour of bdrv_has_zero_init() to default
to 0. In the review for Sheepdog it turned out that enabling it is safe,
so that commit updated one BlockDriver definition of sheepdog to use
bdrv_has_zero_init_1, missed however that there are more BlockDrivers in
the driver. Fix these now.
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Liu Yuan <namei.unix@gmail.com>
Reviewed-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/sheepdog.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index a506137..afe0533 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2347,6 +2347,7 @@ static BlockDriver bdrv_sheepdog = {
.bdrv_file_open = sd_open,
.bdrv_close = sd_close,
.bdrv_create = sd_create,
+ .bdrv_has_zero_init = bdrv_has_zero_init_1,
.bdrv_getlength = sd_getlength,
.bdrv_truncate = sd_truncate,
@@ -2374,6 +2375,7 @@ static BlockDriver bdrv_sheepdog_tcp = {
.bdrv_file_open = sd_open,
.bdrv_close = sd_close,
.bdrv_create = sd_create,
+ .bdrv_has_zero_init = bdrv_has_zero_init_1,
.bdrv_getlength = sd_getlength,
.bdrv_truncate = sd_truncate,
--
1.8.1.4
next prev parent reply other threads:[~2013-08-06 14:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 14:39 [Qemu-devel] [PULL 00/14] Block fixes for 1.6 Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 01/14] qemu-img: Error out for excess arguments Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 02/14] ignore SIGPIPE in qemu-img and qemu-io Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 03/14] iov: handle EOF in iov_send_recv Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 04/14] qemu-iotests: filter QEMU version in monitor banner Kevin Wolf
2013-08-06 14:39 ` Kevin Wolf [this message]
2013-08-06 14:39 ` [Qemu-devel] [PULL 07/14] vmdk: use unsigned values for on disk header fields Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 08/14] qemu-iotests: add poke_file utility function Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 09/14] qemu-iotests: add empty test case for vmdk Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 10/14] vmdk: check granularity field in opening Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 11/14] vmdk: check l2 table size when opening Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 12/14] vmdk: check l1 size before opening image Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 13/14] vmdk: use heap allocation for whole_grain Kevin Wolf
2013-08-06 14:39 ` [Qemu-devel] [PULL 14/14] vmdk: rename num_gtes_per_gte to num_gtes_per_gt Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375799990-995-6-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).