From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6z0P-00027v-MX for qemu-devel@nongnu.org; Wed, 07 Aug 2013 04:22:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6z0J-0007OS-Pa for qemu-devel@nongnu.org; Wed, 07 Aug 2013 04:22:05 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:45026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6z0J-0007OG-Ir for qemu-devel@nongnu.org; Wed, 07 Aug 2013 04:21:59 -0400 Received: by mail-pa0-f54.google.com with SMTP id kx1so1891777pab.27 for ; Wed, 07 Aug 2013 01:21:58 -0700 (PDT) From: Alexey Kardashevskiy Date: Wed, 7 Aug 2013 18:21:26 +1000 Message-Id: <1375863692-12207-3-git-send-email-aik@ozlabs.ru> In-Reply-To: <1375863692-12207-1-git-send-email-aik@ozlabs.ru> References: <1375863692-12207-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH 2/8] memory: Sanity check that no listeners remain on a destroyed AddressSpace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , "Michael S . Tsirkin" , aik@ozlabs.ru, Alexander Graf , Alex Williamson , qemu-ppc@nongnu.org, Paolo Bonzini , Paul Mackerras , David Gibson From: David Gibson At the moment, most AddressSpace objects last as long as the guest system in practice, but that could well change in future. In addition, for VFIO we will be introducing some private per-AdressSpace information, which must be disposed of before the AddressSpace itself is destroyed. To reduce the chances of subtle bugs in this area, this patch adds asssertions to ensure that when an AddressSpace is destroyed, there are no remaining MemoryListeners using that AS as a filter. Signed-off-by: David Gibson --- memory.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/memory.c b/memory.c index 886f838..ffedde7 100644 --- a/memory.c +++ b/memory.c @@ -1726,11 +1726,18 @@ void address_space_init(AddressSpace *as, MemoryRegion *root, const char *name) void address_space_destroy(AddressSpace *as) { + MemoryListener *listener; + /* Flush out anything from MemoryListeners listening in on this */ memory_region_transaction_begin(); as->root = NULL; memory_region_transaction_commit(); QTAILQ_REMOVE(&address_spaces, as, address_spaces_link); + + QTAILQ_FOREACH(listener, &memory_listeners, link) { + assert(listener->address_space_filter != as); + } + address_space_destroy_dispatch(as); flatview_unref(as->current_map); g_free(as->name); -- 1.8.3.2