qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 03/14] hw/arm/exynos4210: Don't use arm_pic_init_cpu()
Date: Thu,  8 Aug 2013 17:04:05 +0100	[thread overview]
Message-ID: <1375977856-25046-4-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1375977856-25046-1-git-send-email-peter.maydell@linaro.org>

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/exynos4210.c |   16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index 216b9b7..4ebb938 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -137,10 +137,8 @@ void exynos4210_write_secondary(ARMCPU *cpu,
 Exynos4210State *exynos4210_init(MemoryRegion *system_mem,
         unsigned long ram_size)
 {
-    qemu_irq cpu_irq[EXYNOS4210_NCPUS];
     int i, n;
     Exynos4210State *s = g_new(Exynos4210State, 1);
-    qemu_irq *irqp;
     qemu_irq gate_irq[EXYNOS4210_NCPUS][EXYNOS4210_IRQ_GATE_NINPUTS];
     unsigned long mem_size;
     DeviceState *dev;
@@ -152,15 +150,6 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem,
             fprintf(stderr, "Unable to find CPU %d definition\n", n);
             exit(1);
         }
-
-        /* Create PIC controller for each processor instance */
-        irqp = arm_pic_init_cpu(s->cpu[n]);
-
-        /*
-         * Get GICs gpio_in cpu_irq to connect a combiner to them later.
-         * Use only IRQ for a while.
-         */
-        cpu_irq[n] = irqp[ARM_PIC_CPU_IRQ];
     }
 
     /*** IRQs ***/
@@ -178,8 +167,9 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem,
         }
         busdev = SYS_BUS_DEVICE(dev);
 
-        /* Connect IRQ Gate output to cpu_irq */
-        sysbus_connect_irq(busdev, 0, cpu_irq[i]);
+        /* Connect IRQ Gate output to CPU's IRQ line */
+        sysbus_connect_irq(busdev, 0,
+                           qdev_get_gpio_in(DEVICE(s->cpu[i]), ARM_CPU_IRQ));
     }
 
     /* Private memory region and Internal GIC */
-- 
1.7.9.5

  parent reply	other threads:[~2013-08-08 16:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 16:04 [Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 01/14] target-arm: Make IRQ and FIQ gpio lines on the " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 02/14] hw/arm/armv7m: Don't use arm_pic_init_cpu() Peter Maydell
2013-08-08 16:04 ` Peter Maydell [this message]
2013-08-08 16:04 ` [Qemu-devel] [PATCH 04/14] hw/arm/highbank: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 05/14] hw/arm/integratorcp: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 06/14] hw/arm/kzm: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 07/14] hw/arm/musicpal: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 08/14] hw/arm/omap*: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 09/14] hw/arm/realview: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 10/14] hw/arm/strongarm: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 11/14] hw/arm/versatilepb: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 12/14] hw/arm/vexpress: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 13/14] hw/arm/xilinx_zynq: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 14/14] hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu() Peter Maydell
2013-08-20 13:07 ` [Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375977856-25046-4-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).