From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 07/14] hw/arm/musicpal: Don't use arm_pic_init_cpu()
Date: Thu, 8 Aug 2013 17:04:09 +0100 [thread overview]
Message-ID: <1375977856-25046-8-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1375977856-25046-1-git-send-email-peter.maydell@linaro.org>
Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/musicpal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index d715143..4404b8d 100644
--- a/hw/arm/musicpal.c
+++ b/hw/arm/musicpal.c
@@ -1586,7 +1586,6 @@ static void musicpal_init(QEMUMachineInitArgs *args)
const char *kernel_cmdline = args->kernel_cmdline;
const char *initrd_filename = args->initrd_filename;
ARMCPU *cpu;
- qemu_irq *cpu_pic;
qemu_irq pic[32];
DeviceState *dev;
DeviceState *i2c_dev;
@@ -1610,7 +1609,6 @@ static void musicpal_init(QEMUMachineInitArgs *args)
fprintf(stderr, "Unable to find CPU definition\n");
exit(1);
}
- cpu_pic = arm_pic_init_cpu(cpu);
/* For now we use a fixed - the original - RAM size */
memory_region_init_ram(ram, NULL, "musicpal.ram", MP_RAM_DEFAULT_SIZE);
@@ -1622,7 +1620,7 @@ static void musicpal_init(QEMUMachineInitArgs *args)
memory_region_add_subregion(address_space_mem, MP_SRAM_BASE, sram);
dev = sysbus_create_simple(TYPE_MV88W8618_PIC, MP_PIC_BASE,
- cpu_pic[ARM_PIC_CPU_IRQ]);
+ qdev_get_gpio_in(DEVICE(cpu), ARM_CPU_IRQ));
for (i = 0; i < 32; i++) {
pic[i] = qdev_get_gpio_in(dev, i);
}
--
1.7.9.5
next prev parent reply other threads:[~2013-08-08 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 16:04 [Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 01/14] target-arm: Make IRQ and FIQ gpio lines on the " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 02/14] hw/arm/armv7m: Don't use arm_pic_init_cpu() Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 03/14] hw/arm/exynos4210: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 04/14] hw/arm/highbank: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 05/14] hw/arm/integratorcp: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 06/14] hw/arm/kzm: " Peter Maydell
2013-08-08 16:04 ` Peter Maydell [this message]
2013-08-08 16:04 ` [Qemu-devel] [PATCH 08/14] hw/arm/omap*: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 09/14] hw/arm/realview: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 10/14] hw/arm/strongarm: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 11/14] hw/arm/versatilepb: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 12/14] hw/arm/vexpress: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 13/14] hw/arm/xilinx_zynq: " Peter Maydell
2013-08-08 16:04 ` [Qemu-devel] [PATCH 14/14] hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu() Peter Maydell
2013-08-20 13:07 ` [Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375977856-25046-8-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).