From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8aAN-0000ui-Vj for qemu-devel@nongnu.org; Sun, 11 Aug 2013 14:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8aAE-0006vg-Fj for qemu-devel@nongnu.org; Sun, 11 Aug 2013 14:14:59 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:34394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8aAD-0006v0-QG for qemu-devel@nongnu.org; Sun, 11 Aug 2013 14:14:50 -0400 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 11 Aug 2013 23:34:50 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id F1D2BE004F for ; Sun, 11 Aug 2013 23:44:51 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7BIFpVl27263156 for ; Sun, 11 Aug 2013 23:45:52 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7BIEUTB009030 for ; Sun, 11 Aug 2013 23:44:31 +0530 From: "Aneesh Kumar K.V" Date: Sun, 11 Aug 2013 23:44:20 +0530 Message-Id: <1376244860-19714-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH] gdb: Fix gdb error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, =?UTF-8?q?Andreas=20F=C3=A4rber?= Cc: aliguori@us.ibm.com, "Aneesh Kumar K.V" From: "Aneesh Kumar K.V" Don't update the global register count if not requested. Without this patch a remote gdb session gives (gdb) target remote localhost:1234 Remote debugging using localhost:1234 Remote 'g' packet reply is too long: 0000000028000084c000000000ccba50c000000000c ... .... ... (gdb) This is a regression introduce by a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 Signed-off-by: Aneesh Kumar K.V --- gdbstub.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1af25a6..4b58a1e 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -598,6 +598,12 @@ void gdb_register_coprocessor(CPUState *cpu, { GDBRegisterState *s; GDBRegisterState **p; + static int last_reg; + CPUClass *cc = CPU_GET_CLASS(cpu); + + if (!last_reg) { + last_reg = cc->gdb_num_core_regs; + } p = &cpu->gdb_regs; while (*p) { @@ -608,19 +614,21 @@ void gdb_register_coprocessor(CPUState *cpu, } s = g_new0(GDBRegisterState, 1); - s->base_reg = cpu->gdb_num_regs; + s->base_reg = last_reg; s->num_regs = num_regs; s->get_reg = get_reg; s->set_reg = set_reg; s->xml = xml; /* Add to end of list. */ - cpu->gdb_num_regs += num_regs; + last_reg += num_regs; *p = s; if (g_pos) { if (g_pos != s->base_reg) { fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n" "Expected %d got %d\n", xml, g_pos, s->base_reg); + } else { + cpu->gdb_num_regs = last_reg; } } } -- 1.8.1.2