From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Anthony Liguori <aliguori@us.ibm.com>,
Laszlo Ersek <lersek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH for-1.6 0/2] future proof rom loading for cross versiom migration
Date: Mon, 12 Aug 2013 11:49:19 +0300 [thread overview]
Message-ID: <1376295742-28528-1-git-send-email-mst@redhat.com> (raw)
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but
they are not backed by RAM so they don't get migrated.
Each time we'll change at least two bytes in such a ROM this will break
cross-version migration: since we can migrate after BIOS has read the first
byte but before it has read the second one, getting an inconsistent state.
This patchset makes QEMU future-proof against such changes.
Naturally, this only helps for -M 1.6 and up, older machine types
will still have the cross-version migration bug.
I think this should be applied for 1.6, this way we won't
have this problem from 1.7 and on.
Michael S. Tsirkin (2):
memory: export target page size
loader: put FW CFG ROM files into RAM
exec.c | 2 ++
hw/core/loader.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++---
hw/i386/pc_piix.c | 2 ++
hw/i386/pc_q35.c | 2 ++
include/exec/memory.h | 2 ++
include/hw/loader.h | 1 +
6 files changed, 60 insertions(+), 3 deletions(-)
--
MST
next reply other threads:[~2013-08-12 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 8:49 Michael S. Tsirkin [this message]
2013-08-12 8:49 ` [Qemu-devel] [PATCH for-1.6 1/2] memory: export target page size Michael S. Tsirkin
2013-08-12 9:17 ` Peter Maydell
2013-08-12 9:25 ` Michael S. Tsirkin
2013-08-12 8:49 ` [Qemu-devel] [PATCH for-1.6 2/2] loader: put FW CFG ROM files into RAM Michael S. Tsirkin
2013-08-12 9:32 ` Peter Maydell
2013-08-12 10:07 ` Michael S. Tsirkin
2013-08-12 13:57 ` [Qemu-devel] [PATCH for-1.6 0/2] future proof rom loading for cross versiom migration Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376295742-28528-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).