qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v2 for-1.6 0/2] future proof rom loading for cross versiom migration
Date: Mon, 12 Aug 2013 21:15:55 +0300	[thread overview]
Message-ID: <1376310634-20778-1-git-send-email-mst@redhat.com> (raw)

Changes from v1: address comments by Peter Maydell
    - drop useless data=data line
    - rename target_page_size to migration_page_size to make use clear
    Peter, you also suggested somehow hiding this within memory core.
    I don't see a clean way to do this without lots of code
    changes, I think what I propose here is acceptable for 1.6
    and we can rework APIs in time for 1.7.

Please review, and consider for 1.6.

Original cover letter below.

ROM files that are put in FW CFG are copied to guest ram, by BIOS, but
they are not backed by RAM so they don't get migrated.

Each time we'll change at least two bytes in such a ROM this will break
cross-version migration: since we can migrate after BIOS has read the first
byte but before it has read the second one, getting an inconsistent state.

This patchset makes QEMU future-proof against such changes.

Naturally, this only helps for -M 1.6 and up, older machine types
will still have the cross-version migration bug.

I think this should be applied for 1.6, this way we won't
have this problem from 1.7 and on.

Michael S. Tsirkin (2):
  memory: export migration page size
  loader: put FW CFG ROM files into RAM

 arch_init.c           |  3 +++
 hw/core/loader.c      | 53 ++++++++++++++++++++++++++++++++++++++++++++++++---
 hw/i386/pc_piix.c     |  2 ++
 hw/i386/pc_q35.c      |  2 ++
 include/exec/memory.h |  1 +
 include/hw/loader.h   |  1 +
 6 files changed, 59 insertions(+), 3 deletions(-)

-- 
MST

             reply	other threads:[~2013-08-12 18:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 18:15 Michael S. Tsirkin [this message]
2013-08-12 18:15 ` [Qemu-devel] [PATCH v2 for-1.6 v2 1/2] memory: export migration page size Michael S. Tsirkin
2013-08-12 18:16 ` [Qemu-devel] [PATCH v2 for-1.6 v2 2/2] loader: put FW CFG ROM files into RAM Michael S. Tsirkin
2013-08-12 18:37   ` Peter Maydell
2013-08-12 18:56     ` Michael S. Tsirkin
2013-08-13 14:47       ` Paolo Bonzini
2013-08-13 15:11         ` Michael S. Tsirkin
2013-08-12 22:03     ` Paolo Bonzini
2013-08-12 18:18 ` [Qemu-devel] [PATCH v2 for-1.6 0/2] future proof rom loading for cross versiom migration Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376310634-20778-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).