From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vZg-0003Tx-35 for qemu-devel@nongnu.org; Mon, 12 Aug 2013 13:06:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8vZX-0005G4-Hu for qemu-devel@nongnu.org; Mon, 12 Aug 2013 13:06:31 -0400 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:42415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8vZX-0005En-8c for qemu-devel@nongnu.org; Mon, 12 Aug 2013 13:06:23 -0400 Received: by mail-ea0-f176.google.com with SMTP id q16so3565133ead.35 for ; Mon, 12 Aug 2013 10:06:21 -0700 (PDT) Message-ID: <1376327167.10576.7.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Mon, 12 Aug 2013 20:06:07 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Mon, 2013-08-12 at 18:28 +0200, Michal Novotny wrote: > Output error message using qemu's error_report() function when user > provides the invalid machine type on the command line. This also saves > time to find what issue is when you downgrade from one version of qemu > to another that doesn't support required machine type yet (the version > user downgraded to have to have this patch applied too, of course). > > Signed-off-by: Michal Novotny > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Marcel Apfelbaum > diff --git a/vl.c b/vl.c > index f422a1c..9b4a3f9 100644 > --- a/vl.c > +++ b/vl.c > @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) > if (machine) { > return machine; > } > + > + if (name && !is_help_option(name)) { > + error_report("Unsupported machine type"); > + } > + > printf("Supported machines are:\n"); > for (m = first_machine; m != NULL; m = m->next) { > if (m->alias) {