qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: claudio.fontana@huawei.com, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [RFC 13/14] tcg-aarch64: Use adrp in tcg_out_movi
Date: Mon, 12 Aug 2013 11:44:54 -0700	[thread overview]
Message-ID: <1376333095-24385-14-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1376333095-24385-1-git-send-email-rth@twiddle.net>

Loading an qemu pointer as an immediate happens often:

- exit_tb $0x7fa8140013
+ exit_tb $0x7f81ee0013
...
- :  d2800260        mov     x0, #0x13
- :  f2b50280        movk    x0, #0xa814, lsl #16
- :  f2c00fe0        movk    x0, #0x7f, lsl #32
+ :  90ff1000        adrp    x0, 0x7f81ee0000
+ :  91004c00        add     x0, x0, #0x13

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/aarch64/tcg-target.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 3ea5db7..a03da58 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aarch64/tcg-target.c
@@ -298,6 +298,10 @@ typedef enum {
     INSN_RET   = 0xd65f0000,
     INSN_B_C   = 0x54000000,
 
+    /* PC relative addressing instructions */
+    INSN_ADR   = 0x10000000,
+    INSN_ADRP  = 0x90000000,
+
     /* System instructions */
     INSN_NOP   = 0xd503201f,
 } AArch64Insn;
@@ -554,6 +558,20 @@ static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg rd,
         return;
     }
 
+    /* Look for host pointer values within 4G of the PC.  This happens
+       often when loading pointers to QEMU's data structures.  */
+    valid = (value >> 12) - ((intptr_t)s->code_ptr >> 12);
+    if (valid == sextract64(valid, 0, 21)) {
+        insn  = INSN_ADRP | rd;
+        insn |= (valid & 3) << 29;
+        insn |= (valid & 0x1ffffc) << (5 - 2);
+        tcg_out32(s, insn);
+        if (value & 0xfff) {
+            tcg_out_aimm(s, INSN_ADDI, ext, rd, rd, value & 0xfff);
+        }
+        return;
+    }
+
     /* Would it take fewer insns to load the inverse?  */
     wantinv = 0;
     for (i = 0; i < 64; i += 16) {
-- 
1.8.3.1

  parent reply	other threads:[~2013-08-12 18:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 18:44 [Qemu-devel] [RFC 00/14] tcg aarch64 improvements Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 01/14] tcg-aarch64: Allow immediate operands to add and sub Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 02/14] tcg-aarch64: Allow immediate operands to and, or, xor Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 03/14] tcg-aarch64: Allow immediate operands to compare Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 04/14] tcg-aarch64: Convert from opcode enums to insn enums Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 05/14] tcg-aarch64: Support andc, orc, eqv, not Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 06/14] tcg-aarch64: Handle zero as first argument to sub Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 07/14] tcg-aarch64: Support movcond Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 08/14] tcg-aarch64: Support deposit Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 09/14] tcg-aarch64: Support add2, sub2 Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 10/14] tcg-aarch64: Support div, mulu2 Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 11/14] tcg-aarch64: Improve tcg_out_movi Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 12/14] tcg-aarch64: Avoid add with zero in tlb load Richard Henderson
2013-08-12 18:44 ` Richard Henderson [this message]
2013-08-12 18:44 ` [Qemu-devel] [RFC 14/14] tcg-aarch64: Pass return address to load/store helpers directly Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376333095-24385-14-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=claudio.fontana@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).