From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: claudio.fontana@huawei.com, Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [RFC 07/14] tcg-aarch64: Support movcond
Date: Mon, 12 Aug 2013 11:44:48 -0700 [thread overview]
Message-ID: <1376333095-24385-8-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1376333095-24385-1-git-send-email-rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/aarch64/tcg-target.c | 19 ++++++++++++++++++-
tcg/aarch64/tcg-target.h | 4 ++--
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
index 88bbfd2..f0febc9 100644
--- a/tcg/aarch64/tcg-target.c
+++ b/tcg/aarch64/tcg-target.c
@@ -267,6 +267,7 @@ typedef enum {
INSN_EXTR = 0x13800000,
/* Conditional select instructions */
+ INSN_CSEL = 0x1a800000,
INSN_CSINC = 0x1a800400,
/* Branch instructions */
@@ -673,6 +674,13 @@ static inline void tcg_out_cset(TCGContext *s, AArch64Ext ext,
tcg_out32(s, base | ext | cond << 12 | rd);
}
+static inline void tcg_out_csel(TCGContext *s, AArch64Ext ext, TCGReg rd,
+ TCGReg rn, TCGReg rm, TCGCond c)
+{
+ unsigned int cond = tcg_cond_to_aarch64[c];
+ tcg_out32(s, INSN_CSEL | ext | rm << 16 | cond << 12 | rn << 5 | rd);
+}
+
static inline void tcg_out_goto(TCGContext *s, tcg_target_long target)
{
tcg_target_long offset;
@@ -1453,6 +1461,13 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
tcg_out_cset(s, 0, args[0], args[3]);
break;
+ case INDEX_op_movcond_i64:
+ ext = E64; /* fall through */
+ case INDEX_op_movcond_i32:
+ tcg_out_cmp(s, ext, args[1], args[2], const_args[2]);
+ tcg_out_csel(s, ext, args[0], REG0(3), REG0(4), args[5]);
+ break;
+
case INDEX_op_qemu_ld8u:
tcg_out_qemu_ld(s, args, 0 | 0);
break;
@@ -1600,9 +1615,11 @@ static const TCGTargetOpDef aarch64_op_defs[] = {
{ INDEX_op_rotr_i64, { "r", "r", "ri" } },
{ INDEX_op_brcond_i32, { "r", "rC" } },
- { INDEX_op_setcond_i32, { "r", "r", "rC" } },
{ INDEX_op_brcond_i64, { "r", "rC" } },
+ { INDEX_op_setcond_i32, { "r", "r", "rC" } },
{ INDEX_op_setcond_i64, { "r", "r", "rC" } },
+ { INDEX_op_movcond_i32, { "r", "r", "rC", "rZ", "rZ" } },
+ { INDEX_op_movcond_i64, { "r", "r", "rC", "rZ", "rZ" } },
{ INDEX_op_qemu_ld8u, { "r", "l" } },
{ INDEX_op_qemu_ld8s, { "r", "l" } },
diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h
index ffe9429..7d87870 100644
--- a/tcg/aarch64/tcg-target.h
+++ b/tcg/aarch64/tcg-target.h
@@ -56,7 +56,7 @@ typedef enum {
#define TCG_TARGET_HAS_nand_i32 0
#define TCG_TARGET_HAS_nor_i32 0
#define TCG_TARGET_HAS_deposit_i32 0
-#define TCG_TARGET_HAS_movcond_i32 0
+#define TCG_TARGET_HAS_movcond_i32 1
#define TCG_TARGET_HAS_add2_i32 0
#define TCG_TARGET_HAS_sub2_i32 0
#define TCG_TARGET_HAS_mulu2_i32 0
@@ -82,7 +82,7 @@ typedef enum {
#define TCG_TARGET_HAS_nand_i64 0
#define TCG_TARGET_HAS_nor_i64 0
#define TCG_TARGET_HAS_deposit_i64 0
-#define TCG_TARGET_HAS_movcond_i64 0
+#define TCG_TARGET_HAS_movcond_i64 1
#define TCG_TARGET_HAS_add2_i64 0
#define TCG_TARGET_HAS_sub2_i64 0
#define TCG_TARGET_HAS_mulu2_i64 0
--
1.8.3.1
next prev parent reply other threads:[~2013-08-12 18:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 18:44 [Qemu-devel] [RFC 00/14] tcg aarch64 improvements Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 01/14] tcg-aarch64: Allow immediate operands to add and sub Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 02/14] tcg-aarch64: Allow immediate operands to and, or, xor Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 03/14] tcg-aarch64: Allow immediate operands to compare Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 04/14] tcg-aarch64: Convert from opcode enums to insn enums Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 05/14] tcg-aarch64: Support andc, orc, eqv, not Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 06/14] tcg-aarch64: Handle zero as first argument to sub Richard Henderson
2013-08-12 18:44 ` Richard Henderson [this message]
2013-08-12 18:44 ` [Qemu-devel] [RFC 08/14] tcg-aarch64: Support deposit Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 09/14] tcg-aarch64: Support add2, sub2 Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 10/14] tcg-aarch64: Support div, mulu2 Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 11/14] tcg-aarch64: Improve tcg_out_movi Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 12/14] tcg-aarch64: Avoid add with zero in tlb load Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 13/14] tcg-aarch64: Use adrp in tcg_out_movi Richard Henderson
2013-08-12 18:44 ` [Qemu-devel] [RFC 14/14] tcg-aarch64: Pass return address to load/store helpers directly Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376333095-24385-8-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=claudio.fontana@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).