* [Qemu-devel] [PATCH 1/1] block: Dont ignore previously set bdrv_flags
@ 2013-08-14 12:26 M. Mohan Kumar
2013-08-14 13:22 ` [Qemu-devel] [PATCH for-1.6] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: M. Mohan Kumar @ 2013-08-14 12:26 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: M. Mohan Kumar
From: "M. Mohan Kumar" <mohan@in.ibm.com>
bdrv_flags is set by bdrv_parse_discard_flags(), but later it is reset
to zero.
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
blockdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index e174b7d..bc7016a 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -454,7 +454,6 @@ static DriveInfo *blockdev_init(QemuOpts *all_opts,
}
}
- bdrv_flags = 0;
if (qemu_opt_get_bool(opts, "cache.writeback", true)) {
bdrv_flags |= BDRV_O_CACHE_WB;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] block: Dont ignore previously set bdrv_flags
2013-08-14 12:26 [Qemu-devel] [PATCH 1/1] block: Dont ignore previously set bdrv_flags M. Mohan Kumar
@ 2013-08-14 13:22 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-08-14 13:22 UTC (permalink / raw)
To: M. Mohan Kumar; +Cc: qemu-trivial, Kevin Wolf, Anthony Liguori, qemu-devel
On Wed, Aug 14, 2013 at 05:56:41PM +0530, M. Mohan Kumar wrote:
> From: "M. Mohan Kumar" <mohan@in.ibm.com>
>
> bdrv_flags is set by bdrv_parse_discard_flags(), but later it is reset
> to zero.
>
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
> blockdev.c | 1 -
> 1 file changed, 1 deletion(-)
Anthony: Please merge this directly into QEMU 1.6, it's a regression
from QEMU 1.5.
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-14 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-14 12:26 [Qemu-devel] [PATCH 1/1] block: Dont ignore previously set bdrv_flags M. Mohan Kumar
2013-08-14 13:22 ` [Qemu-devel] [PATCH for-1.6] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).