From: Alex Bligh <alex@alex.org.uk>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Alex Bligh <alex@alex.org.uk>,
Jan Kiszka <jan.kiszka@siemens.com>,
liu ping fan <qemulist@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>,
rth@twiddle.net
Subject: [Qemu-devel] [PATCHv11 22/31] aio / timers: Remove legacy qemu_clock_deadline & qemu_timerlist_deadline
Date: Thu, 15 Aug 2013 21:34:30 +0100 [thread overview]
Message-ID: <1376598879-18976-23-git-send-email-alex@alex.org.uk> (raw)
In-Reply-To: <1376598879-18976-1-git-send-email-alex@alex.org.uk>
Remove qemu_clock_deadline and qemu_timerlist_deadline now we are using
the ns functions throughout.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
include/qemu/timer.h | 16 ----------------
qemu-timer.c | 20 --------------------
2 files changed, 36 deletions(-)
diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index b77a1bc..3e9506c 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -140,7 +140,6 @@ bool qemu_clock_has_timers(QEMUClock *clock);
* an expired timer
*/
bool qemu_clock_expired(QEMUClock *clock);
-int64_t qemu_clock_deadline(QEMUClock *clock);
/**
* qemu_clock_deadline_ns:
@@ -246,21 +245,6 @@ bool timerlist_has_timers(QEMUTimerList *timer_list);
bool timerlist_expired(QEMUTimerList *timer_list);
/**
- * timerlist_deadline:
- * @timer_list: the timer list to operate on
- *
- * Determine the deadline for a timer_list. This is
- * a legacy function which returns INT32_MAX if the
- * timer list has no timers or if the earliest timer
- * expires later than INT32_MAX nanoseconds away.
- *
- * Returns: the number of nanoseconds until the earliest
- * timer expires or INT32_MAX in the situations listed
- * above
- */
-int64_t timerlist_deadline(QEMUTimerList *timer_list);
-
-/**
* timerlist_deadline_ns:
* @timer_list: the timer list to operate on
*
diff --git a/qemu-timer.c b/qemu-timer.c
index acc3bcf..2f27c8d 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -176,26 +176,6 @@ bool qemu_clock_expired(QEMUClock *clock)
return timerlist_expired(clock->main_loop_timerlist);
}
-int64_t timerlist_deadline(QEMUTimerList *timer_list)
-{
- /* To avoid problems with overflow limit this to 2^32. */
- int64_t delta = INT32_MAX;
-
- if (timer_list->clock->enabled && timer_list->active_timers) {
- delta = timer_list->active_timers->expire_time -
- qemu_get_clock_ns(timer_list->clock);
- }
- if (delta < 0) {
- delta = 0;
- }
- return delta;
-}
-
-int64_t qemu_clock_deadline(QEMUClock *clock)
-{
- return timerlist_deadline(clock->main_loop_timerlist);
-}
-
/*
* As above, but return -1 for no deadline, and do not cap to 2^32
* as we know the result is always positive.
--
1.7.9.5
next prev parent reply other threads:[~2013-08-15 20:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 20:34 [Qemu-devel] [PATCHv11 00/31] aio / timers: Add AioContext timers and use ppoll Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 01/31] aio / timers: Rename qemu_timer_* functions Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 02/31] aio / timers: Rename qemu_new_clock and expose clock types Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 03/31] aio / timers: add qemu-timer.c utility functions Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 04/31] aio / timers: Consistent treatment of disabled clocks for deadlines Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 05/31] aio / timers: add ppoll support with qemu_poll_ns Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 06/31] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 07/31] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 09/31] aio / timers: Untangle include files Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 10/31] aio / timers: Add QEMUTimerListGroup and helper functions Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 11/31] aio / timers: Add QEMUTimerListGroup to AioContext Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 12/31] aio / timers: Add a notify callback to QEMUTimerList Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers Alex Bligh
2013-08-20 3:08 ` Wenchao Xia
2013-08-20 6:48 ` Alex Bligh
2013-08-20 7:19 ` Wenchao Xia
2013-08-20 9:29 ` Alex Bligh
2013-08-20 11:19 ` Wenchao Xia
2013-08-20 13:35 ` Alex Bligh
2013-08-21 9:01 ` Stefan Hajnoczi
2013-08-21 10:07 ` Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 14/31] aio / timers: Add aio_timer_init & aio_timer_new wrappers Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 15/31] aio / timers: Convert aio_poll to use AioContext timers' deadline Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 16/31] aio / timers: Convert mainloop to use timeout Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 17/31] aio / timers: On timer modification, qemu_notify or aio_notify Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 18/31] aio / timers: Introduce new API timer_new and friends Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 19/31] aio / timers: Use all timerlists in icount warp calculations Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 20/31] aio / timers: Add documentation and new format calls Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 21/31] aio / timers: Remove alarm timers Alex Bligh
2013-08-15 20:34 ` Alex Bligh [this message]
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 23/31] aio / timers: Add qemu_clock_get_ms and qemu_clock_get_ms Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 24/31] aio / timers: Rearrange timer.h & make legacy functions call non-legacy Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 25/31] aio / timers: Remove main_loop_timerlist Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 26/31] aio / timers: Convert rtc_clock to be a QEMUClockType Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 27/31] aio / timers: convert block_job_sleep_ns and co_sleep_ns to new API Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 28/31] aio / timers: Add test harness for AioContext timers Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 29/31] aio / timers: Add scripts/switch-timer-api Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 30/31] aio / timers: Switch entire codebase to the new timer API Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 31/31] aio / timers: Remove legacy interface Alex Bligh
2013-08-16 15:24 ` [Qemu-devel] [PATCHv11 00/31] aio / timers: Add AioContext timers and use ppoll Stefan Hajnoczi
2013-08-16 15:37 ` Alex Bligh
2013-08-19 12:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376598879-18976-23-git-send-email-alex@alex.org.uk \
--to=alex@alex.org.uk \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).