qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Bligh <alex@alex.org.uk>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Alex Bligh <alex@alex.org.uk>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	liu ping fan <qemulist@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>,
	rth@twiddle.net
Subject: [Qemu-devel] [PATCHv11 07/31] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress
Date: Thu, 15 Aug 2013 21:34:15 +0100	[thread overview]
Message-ID: <1376598879-18976-8-git-send-email-alex@alex.org.uk> (raw)
In-Reply-To: <1376598879-18976-1-git-send-email-alex@alex.org.uk>

Make qemu_run_timers and qemu_run_all_timers return progress
so that aio_poll etc. can determine whether a timer has been
run.

Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
 include/qemu/timer.h |   21 +++++++++++++++++++--
 qemu-timer.c         |   18 ++++++++++++------
 2 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index fcc3ca0..fcb6a42 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -92,8 +92,25 @@ bool timer_pending(QEMUTimer *ts);
 bool timer_expired(QEMUTimer *timer_head, int64_t current_time);
 uint64_t timer_expire_time_ns(QEMUTimer *ts);
 
-void qemu_run_timers(QEMUClock *clock);
-void qemu_run_all_timers(void);
+/**
+ * qemu_run_timers:
+ * @clock: clock on which to operate
+ *
+ * Run all the timers associated with a clock.
+ *
+ * Returns: true if any timer ran.
+ */
+bool qemu_run_timers(QEMUClock *clock);
+
+/**
+ * qemu_run_all_timers:
+ *
+ * Run all the timers associated with every clock.
+ *
+ * Returns: true if any timer ran.
+ */
+bool qemu_run_all_timers(void);
+
 void configure_alarms(char const *opt);
 void init_clocks(void);
 int init_timer_alarm(void);
diff --git a/qemu-timer.c b/qemu-timer.c
index f224b62..4a10315 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -446,13 +446,14 @@ bool timer_expired(QEMUTimer *timer_head, int64_t current_time)
     return timer_expired_ns(timer_head, current_time * timer_head->scale);
 }
 
-void qemu_run_timers(QEMUClock *clock)
+bool qemu_run_timers(QEMUClock *clock)
 {
     QEMUTimer *ts;
     int64_t current_time;
+    bool progress = false;
    
     if (!clock->enabled)
-        return;
+        return progress;
 
     current_time = qemu_get_clock_ns(clock);
     for(;;) {
@@ -466,7 +467,9 @@ void qemu_run_timers(QEMUClock *clock)
 
         /* run the callback (the timer list can be modified) */
         ts->cb(ts->opaque);
+        progress = true;
     }
+    return progress;
 }
 
 int64_t qemu_get_clock_ns(QEMUClock *clock)
@@ -521,20 +524,23 @@ uint64_t timer_expire_time_ns(QEMUTimer *ts)
     return timer_pending(ts) ? ts->expire_time : -1;
 }
 
-void qemu_run_all_timers(void)
+bool qemu_run_all_timers(void)
 {
+    bool progress = false;
     alarm_timer->pending = false;
 
     /* vm time timers */
-    qemu_run_timers(vm_clock);
-    qemu_run_timers(rt_clock);
-    qemu_run_timers(host_clock);
+    progress |= qemu_run_timers(vm_clock);
+    progress |= qemu_run_timers(rt_clock);
+    progress |= qemu_run_timers(host_clock);
 
     /* rearm timer, if not periodic */
     if (alarm_timer->expired) {
         alarm_timer->expired = false;
         qemu_rearm_alarm_timer(alarm_timer);
     }
+
+    return progress;
 }
 
 #ifdef _WIN32
-- 
1.7.9.5

  parent reply	other threads:[~2013-08-15 20:35 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 20:34 [Qemu-devel] [PATCHv11 00/31] aio / timers: Add AioContext timers and use ppoll Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 01/31] aio / timers: Rename qemu_timer_* functions Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 02/31] aio / timers: Rename qemu_new_clock and expose clock types Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 03/31] aio / timers: add qemu-timer.c utility functions Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 04/31] aio / timers: Consistent treatment of disabled clocks for deadlines Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 05/31] aio / timers: add ppoll support with qemu_poll_ns Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 06/31] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack Alex Bligh
2013-08-15 20:34 ` Alex Bligh [this message]
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 09/31] aio / timers: Untangle include files Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 10/31] aio / timers: Add QEMUTimerListGroup and helper functions Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 11/31] aio / timers: Add QEMUTimerListGroup to AioContext Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 12/31] aio / timers: Add a notify callback to QEMUTimerList Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers Alex Bligh
2013-08-20  3:08   ` Wenchao Xia
2013-08-20  6:48     ` Alex Bligh
2013-08-20  7:19       ` Wenchao Xia
2013-08-20  9:29         ` Alex Bligh
2013-08-20 11:19           ` Wenchao Xia
2013-08-20 13:35             ` Alex Bligh
2013-08-21  9:01   ` Stefan Hajnoczi
2013-08-21 10:07     ` Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 14/31] aio / timers: Add aio_timer_init & aio_timer_new wrappers Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 15/31] aio / timers: Convert aio_poll to use AioContext timers' deadline Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 16/31] aio / timers: Convert mainloop to use timeout Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 17/31] aio / timers: On timer modification, qemu_notify or aio_notify Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 18/31] aio / timers: Introduce new API timer_new and friends Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 19/31] aio / timers: Use all timerlists in icount warp calculations Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 20/31] aio / timers: Add documentation and new format calls Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 21/31] aio / timers: Remove alarm timers Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 22/31] aio / timers: Remove legacy qemu_clock_deadline & qemu_timerlist_deadline Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 23/31] aio / timers: Add qemu_clock_get_ms and qemu_clock_get_ms Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 24/31] aio / timers: Rearrange timer.h & make legacy functions call non-legacy Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 25/31] aio / timers: Remove main_loop_timerlist Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 26/31] aio / timers: Convert rtc_clock to be a QEMUClockType Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 27/31] aio / timers: convert block_job_sleep_ns and co_sleep_ns to new API Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 28/31] aio / timers: Add test harness for AioContext timers Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 29/31] aio / timers: Add scripts/switch-timer-api Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 30/31] aio / timers: Switch entire codebase to the new timer API Alex Bligh
2013-08-15 20:34 ` [Qemu-devel] [PATCHv11 31/31] aio / timers: Remove legacy interface Alex Bligh
2013-08-16 15:24 ` [Qemu-devel] [PATCHv11 00/31] aio / timers: Add AioContext timers and use ppoll Stefan Hajnoczi
2013-08-16 15:37   ` Alex Bligh
2013-08-19 12:40     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376598879-18976-8-git-send-email-alex@alex.org.uk \
    --to=alex@alex.org.uk \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kwolf@redhat.com \
    --cc=morita.kazutaka@lab.ntt.co.jp \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemulist@gmail.com \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).