qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: pbonzini@redhat.com, aliguori@us.ibm.com, hch@lst.de,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 5/7] raw_bsd: add raw_create_options
Date: Fri, 16 Aug 2013 16:15:05 +0200	[thread overview]
Message-ID: <1376662507-5212-6-git-send-email-lersek@redhat.com> (raw)
In-Reply-To: <1376662507-5212-1-git-send-email-lersek@redhat.com>

On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 4) There is another member, .create_options, which is an array of
> QEMUOptionParameter structs, terminated by an all-zero item.  The only
> option you need is for the virtual disk size.  You will find something
> to copy from in other block drivers, for example block/qcow2.c.

Code taken and adapted from "block/qcow2.c", as suggested. The code being
copied/modified is blamed on

    commit 20d97356c9df6d68fbd37d6334fdb7063f24eab6
    Author: Blue Swirl <blauwirbel@gmail.com>
    Date:   Fri Apr 23 20:19:47 2010 +0000

        Fix OpenBSD build

and

    commit 7c80ab3f21f0b1342f23057d4345ae266c7348d9
    Author: Jes Sorensen <Jes.Sorensen@redhat.com>
    Date:   Fri Dec 17 16:02:39 2010 +0100

        block/qcow2.c: rename qcow_ functions to qcow2_

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 block/raw_bsd.c |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 86e018d..12debb2 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -1,6 +1,7 @@
 /* BlockDriver implementation for "raw"
  *
- * Copyright (C) 2013, Red Hat, Inc.
+ * Copyright (C) 2010, 2013, Red Hat, Inc.
+ * Copyright (C) 2010, Blue Swirl <blauwirbel@gmail.com>
  *
  * Author:
  *   Laszlo Ersek <lersek@redhat.com>
@@ -25,6 +26,16 @@
  */
 
 #include "block/block_int.h"
+#include "qemu/option.h"
+
+static const QEMUOptionParameter raw_create_options[] = {
+    {
+        .name = BLOCK_OPT_SIZE,
+        .type = OPT_SIZE,
+        .help = "Virtual disk size"
+    },
+    { 0 }
+};
 
 static TYPE raw_reopen_prepare(BlockDriverState *bs)
 {
-- 
1.7.1

  parent reply	other threads:[~2013-08-16 14:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 14:15 [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw" Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 1/7] add skeleton for BSD licensed "raw" BlockDriver Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 2/7] raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev() Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 3/7] raw_bsd: add raw_create() Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 4/7] raw_bsd: introduce "special members" Laszlo Ersek
2013-08-20  8:11   ` Kevin Wolf
2013-08-16 14:15 ` Laszlo Ersek [this message]
2013-08-16 14:15 ` [Qemu-devel] [PATCH 6/7] raw_bsd: register bdrv_raw Laszlo Ersek
2013-08-16 14:15 ` [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o" Laszlo Ersek
2013-08-18 14:29   ` Paolo Bonzini
2013-08-20  7:51     ` Kevin Wolf
2013-08-16 14:59 ` [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw" Anthony Liguori
2013-08-16 15:06   ` Daniel P. Berrange
2013-08-18 14:25   ` Paolo Bonzini
2013-08-19 16:24     ` Laszlo Ersek
2013-08-20  8:21 ` Kevin Wolf
2013-08-21  8:20   ` Laszlo Ersek
2013-08-21  9:03     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376662507-5212-6-git-send-email-lersek@redhat.com \
    --to=lersek@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=hch@lst.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).