From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org,
Anthony PERARD <anthony.perard@citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: [Qemu-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memory variable.
Date: Fri, 16 Aug 2013 15:46:49 +0100 [thread overview]
Message-ID: <1376664409-2695-1-git-send-email-anthony.perard@citrix.com> (raw)
In some cases (Xen), it will not be initialized before to be used. This
leads to segv.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
It works with this simple initialization to NULL, but would it be
necessary (or better) to assign a proper value to this variables ?
---
hw/i386/pc_piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 6e1e654..596d433 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -86,7 +86,7 @@ static void pc_init1(MemoryRegion *system_memory,
BusState *idebus[MAX_IDE_BUS];
ISADevice *rtc_state;
ISADevice *floppy;
- MemoryRegion *ram_memory;
+ MemoryRegion *ram_memory = NULL;
MemoryRegion *pci_memory;
MemoryRegion *rom_memory;
DeviceState *icc_bridge;
--
Anthony PERARD
next reply other threads:[~2013-08-16 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 14:46 Anthony PERARD [this message]
2013-08-26 15:00 ` [Qemu-devel] [Xen-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memory variable Fabio Fantoni
2013-08-29 8:32 ` Fabio Fantoni
2013-08-29 10:59 ` Stefano Stabellini
2013-08-29 11:05 ` Stefano Stabellini
2013-08-29 8:48 ` [Qemu-devel] " Peter Maydell
2013-08-29 9:00 ` Paolo Bonzini
2013-08-29 9:42 ` [Qemu-devel] [Xen-devel] " Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376664409-2695-1-git-send-email-anthony.perard@citrix.com \
--to=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).