From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAQ4J-0000L7-85 for qemu-devel@nongnu.org; Fri, 16 Aug 2013 15:52:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAQ4B-0001Ws-N5 for qemu-devel@nongnu.org; Fri, 16 Aug 2013 15:52:19 -0400 Received: from qemu.weilnetz.de ([37.221.198.45]:33899 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAQ4B-0001WR-HM for qemu-devel@nongnu.org; Fri, 16 Aug 2013 15:52:11 -0400 From: Stefan Weil Date: Fri, 16 Aug 2013 21:51:53 +0200 Message-Id: <1376682713-18957-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] w32: Fix broken out-of-tree builds (missing version.o) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Paolo Bonzini , Anthony Liguori , Michael Roth , Stefan Weil Commit 0b516ef0dfad9a7b34c675c98e8ec92ab4d38466 added version.o to all executables, but broke out-of-tree builds: for those builds the pattern rule %.o: %.rc from rules.mak does not match, so version.o was no longer built. Adding explicit build rules fixes this. Reported-by: Michael Roth Signed-off-by: Stefan Weil --- Hello Michael, thank you for the report and your hint for a possible fix. This is still not the final solution which should build version.o at link time, but it is a minimal fix for the broken build. Regards, Stefan Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 4d257f1..806946e 100644 --- a/Makefile +++ b/Makefile @@ -168,7 +168,9 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES) bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS) $(BUILD_DIR)/version.o: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h | $(BUILD_DIR)/version.lo + $(call quiet-command,$(WINDRES) -I$(BUILD_DIR) -o $@ $<," RC version.o") $(BUILD_DIR)/version.lo: $(SRC_PATH)/version.rc $(BUILD_DIR)/config-host.h + $(call quiet-command,$(WINDRES) -I$(BUILD_DIR) -o $@ $<," RC version.lo") Makefile: $(version-obj-y) $(version-lobj-y) -- 1.7.10.4