From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Miroslav Rezanina" <mrezanin@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable
Date: Mon, 19 Aug 2013 16:19:17 +0200 [thread overview]
Message-ID: <1376921957.5693.21.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <52122489.7050307@redhat.com>
On Mo, 2013-08-19 at 15:58 +0200, Paolo Bonzini wrote:
> Il 19/08/2013 15:41, Andreas Färber ha scritto:
> > By my reading of `git grep CONFIG_USB_BLUETOOTH` it isn't disappearing,
> > check default-configs/usb.mak. All targets that include usb.mak will
> > have CONFIG_USB_BLUETOOTH.
> >
> > It's only used in the build system and with this patch in vl.c, so
> > assuming that Miroslav has checked that the build succeeds for all
> > targets, this should be fine, I guess.
>
> Actually, CONFIG_* symbols for devices are _not_ exposed to vl.c. Blue
> Swirl specifically wanted that to happen. So I'm afraid Mirek's patch
> breaks "-usb bt" even if CONFIG_USB_BLUETOOTH is set to y.
"-usbdevice bt", to be exact.
I'd suggest to switch bluetooth over to use usb_legacy_register() to
parse+handle the legacy -usbdevice cmd line option and zap the vl.c
dependency this way.
cheers,
Gerd
next prev parent reply other threads:[~2013-08-19 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 10:48 [Qemu-devel] [PATCH] Make usb-bt-dongle configurable Miroslav Rezanina
2013-08-19 12:31 ` Andreas Färber
2013-08-19 13:30 ` Laszlo Ersek
2013-08-19 13:41 ` Andreas Färber
2013-08-19 13:58 ` Paolo Bonzini
2013-08-19 14:19 ` Gerd Hoffmann [this message]
2013-08-19 12:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376921957.5693.21.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=lersek@redhat.com \
--cc=mrezanin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).