From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VBQIq-00050m-Ky
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 10:19:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VBQIk-0001QL-LC
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 10:19:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43018)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VBQIk-0001QH-Dn
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 10:19:22 -0400
Message-ID: <1376921957.5693.21.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 19 Aug 2013 16:19:17 +0200
In-Reply-To: <52122489.7050307@redhat.com>
References: <52081254.597343.1376909324949.JavaMail.root@redhat.com>
	<52121014.8050108@suse.de> <52121DD8.9020506@redhat.com>
	<5212207A.9010408@suse.de> <52122489.7050307@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Miroslav Rezanina <mrezanin@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>, qemu-devel@nongnu.org

On Mo, 2013-08-19 at 15:58 +0200, Paolo Bonzini wrote:
> Il 19/08/2013 15:41, Andreas F=C3=A4rber ha scritto:
> > By my reading of `git grep CONFIG_USB_BLUETOOTH` it isn't disappearin=
g,
> > check default-configs/usb.mak. All targets that include usb.mak will
> > have CONFIG_USB_BLUETOOTH.
> >=20
> > It's only used in the build system and with this patch in vl.c, so
> > assuming that Miroslav has checked that the build succeeds for all
> > targets, this should be fine, I guess.
>=20
> Actually, CONFIG_* symbols for devices are _not_ exposed to vl.c.  Blue
> Swirl specifically wanted that to happen.  So I'm afraid Mirek's patch
> breaks "-usb bt" even if CONFIG_USB_BLUETOOTH is set to y.

"-usbdevice bt", to be exact.

I'd suggest to switch bluetooth over to use usb_legacy_register() to
parse+handle the legacy -usbdevice cmd line option and zap the vl.c
dependency this way.

cheers,
  Gerd