qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: lcapitulino@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 4/8] OptsVisitor: rebase opts_type_uint64() to parse_uint_full()
Date: Tue, 20 Aug 2013 00:35:36 +0200	[thread overview]
Message-ID: <1376951740-23559-5-git-send-email-lersek@redhat.com> (raw)
In-Reply-To: <1376951740-23559-1-git-send-email-lersek@redhat.com>

Simplify the code in preparation for the next patch.

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 qapi/opts-visitor.c |   23 +++++------------------
 1 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 90be583..d8f9a0e 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -407,6 +407,7 @@ opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
     OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
     const QemuOpt *opt;
     const char *str;
+    unsigned long long val;
 
     if (ov->list_mode == LM_UNSIGNED_INTERVAL) {
         *obj = ov->range_next.u;
@@ -417,26 +418,12 @@ opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
     if (!opt) {
         return;
     }
-
     str = opt->str;
-    if (str != NULL) {
-        while (isspace((unsigned char)*str)) {
-            ++str;
-        }
-
-        if (*str != '-' && *str != '\0') {
-            unsigned long long val;
-            char *endptr;
 
-            /* non-empty, non-negative subject sequence */
-            errno = 0;
-            val = strtoull(str, &endptr, 0);
-            if (*endptr == '\0' && errno == 0 && val <= UINT64_MAX) {
-                *obj = val;
-                processed(ov, name);
-                return;
-            }
-        }
+    if (parse_uint_full(str, &val, 0) == 0 && val <= UINT64_MAX) {
+        *obj = val;
+        processed(ov, name);
+        return;
     }
     error_set(errp, QERR_INVALID_PARAMETER_VALUE, opt->name,
               "an uint64 value");
-- 
1.7.1

  parent reply	other threads:[~2013-08-19 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 22:35 [Qemu-devel] [PATCH v2 0/8] OptsVisitor: support / flatten integer ranges for repeating options Laszlo Ersek
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 1/8] OptsVisitor: introduce basic list modes Laszlo Ersek
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 2/8] OptsVisitor: introduce list modes for interval flattening Laszlo Ersek
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 3/8] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS Laszlo Ersek
2013-08-19 22:35 ` Laszlo Ersek [this message]
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 5/8] OptsVisitor: opts_type_uint64(): " Laszlo Ersek
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 6/8] OptsVisitor: don't try to flatten overlong integer ranges Laszlo Ersek
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 7/8] add "test-int128" and "test-bitops" to .gitignore Laszlo Ersek
2013-08-19 22:35 ` [Qemu-devel] [PATCH v2 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening Laszlo Ersek
2013-08-20  1:09 ` [Qemu-devel] [PATCH v2 0/8] OptsVisitor: support / flatten integer ranges for repeating options Wanlong Gao
2013-08-21  7:31   ` Laszlo Ersek
2013-08-20 14:12 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376951740-23559-5-git-send-email-lersek@redhat.com \
    --to=lersek@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).