From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBxpX-0003Ok-Q8 for qemu-devel@nongnu.org; Tue, 20 Aug 2013 22:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBxpS-0007vS-BA for qemu-devel@nongnu.org; Tue, 20 Aug 2013 22:07:27 -0400 Received: from mail-pd0-x235.google.com ([2607:f8b0:400e:c02::235]:64644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBxpS-0007vI-4a for qemu-devel@nongnu.org; Tue, 20 Aug 2013 22:07:22 -0400 Received: by mail-pd0-f181.google.com with SMTP id g10so1193394pdj.12 for ; Tue, 20 Aug 2013 19:07:21 -0700 (PDT) From: Jia Liu Date: Wed, 21 Aug 2013 10:06:49 +0800 Message-Id: <1377050811-11116-2-git-send-email-proljc@gmail.com> In-Reply-To: <1377050811-11116-1-git-send-email-proljc@gmail.com> References: <1377050811-11116-1-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset="utf-8" Subject: [Qemu-devel] [PULL 1/3] hw/openrisc: Avoid using uninitialised variable 'entry' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, xi.wang@gmail.com clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] if (kernel_filename && !qtest_enabled()) { ^~~~~~~~~~~~~~~ hw/openrisc/openrisc_sim.c:91:19: note: uninitialized use occurs here cpu->env.pc = entry; ^~~~~ Fix this by not attempting to change the CPU's starting PC unless we actually loaded a kernel. Signed-off-by: Peter Maydell Reviewed-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index a08f27c..28fa41d 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -86,9 +86,8 @@ static void cpu_openrisc_load_kernel(ram_addr_t ram_size, kernel_filename); exit(1); } + cpu->env.pc = entry; } - - cpu->env.pc = entry; } static void openrisc_sim_init(QEMUMachineInitArgs *args) -- 1.7.12.4 (Apple Git-37)