qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: kwolf@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
	hch@lst.de, anthony@codemonkey.ws, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/7] introduce BSD-licensed block driver for "raw"
Date: Wed, 21 Aug 2013 12:41:16 +0200	[thread overview]
Message-ID: <1377081683-1600-1-git-send-email-lersek@redhat.com> (raw)

v1->v2:
- added comment to raw_probe() [Kevin]
- fixed raw_reopen_prepare() [Paolo & Kevin]
- keeping BSDL: according to the v1 discussion, LGPLv2+ could work too,
  but "but most of the block layer is BSD" [Paolo] and I haven't been
  clearly instructed to switch to LGPLv2+.

  diff --git a/block/raw_bsd.c b/block/raw_bsd.c
  index 07e6f06..ab2b0fd 100644
  --- a/block/raw_bsd.c
  +++ b/block/raw_bsd.c
  @@ -41,10 +41,7 @@ static QEMUOptionParameter raw_create_options[] = {
   static int raw_reopen_prepare(BDRVReopenState *reopen_state,
                                 BlockReopenQueue *queue, Error **errp)
   {
  -    BDRVReopenState tmp = *reopen_state;
  -
  -    tmp.bs = tmp.bs->file;
  -    return bdrv_reopen_prepare(&tmp, queue, errp);
  +    return 0;
   }

   static int coroutine_fn raw_co_readv(BlockDriverState *bs, int64_t sector_num,
  @@ -150,6 +147,9 @@ static void raw_close(BlockDriverState *bs)

   static int raw_probe(const uint8_t *buf, int buf_size, const char *filename)
   {
  +    /* smallest possible positive score so that raw is used if and only if no
  +     * other block driver works
  +     */
       return 1;
   }

v1 blurb:

Paolo asked me to write such a driver based on his textual specification
alone. The first patch captures his email in full, the rest re-quotes
parts that are being implemented.

The tree compiles at each patch. The series passes "make check-block".

"block/raw.c" is not removed because I wanted to keep it out of my
series and out of my brain.

Laszlo Ersek (7):
  add skeleton for BSD licensed "raw" BlockDriver
  raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev()
  raw_bsd: add raw_create()
  raw_bsd: introduce "special members"
  raw_bsd: add raw_create_options
  raw_bsd: register bdrv_raw
  switch raw block driver from "raw.o" to "raw_bsd.o"

 block/Makefile.objs |    2 +-
 block/raw_bsd.c     |  186 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 187 insertions(+), 1 deletions(-)
 create mode 100644 block/raw_bsd.c

             reply	other threads:[~2013-08-21 10:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 10:41 Laszlo Ersek [this message]
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 1/7] add skeleton for BSD licensed "raw" BlockDriver Laszlo Ersek
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 2/7] raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev() Laszlo Ersek
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 3/7] raw_bsd: add raw_create() Laszlo Ersek
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 4/7] raw_bsd: introduce "special members" Laszlo Ersek
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 5/7] raw_bsd: add raw_create_options Laszlo Ersek
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 6/7] raw_bsd: register bdrv_raw Laszlo Ersek
2013-08-21 10:41 ` [Qemu-devel] [PATCH v2 7/7] switch raw block driver from "raw.o" to "raw_bsd.o" Laszlo Ersek
2013-08-28 10:50 ` [Qemu-devel] [PATCH v2 0/7] introduce BSD-licensed block driver for "raw" Laszlo Ersek
2013-08-28 13:17 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377081683-1600-1-git-send-email-lersek@redhat.com \
    --to=lersek@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).