From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5ot-0000eD-1m for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:39:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC5om-0002py-OC for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:39:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC5om-0002pn-H7 for qemu-devel@nongnu.org; Wed, 21 Aug 2013 06:39:12 -0400 From: Laszlo Ersek Date: Wed, 21 Aug 2013 12:41:20 +0200 Message-Id: <1377081683-1600-5-git-send-email-lersek@redhat.com> In-Reply-To: <1377081683-1600-1-git-send-email-lersek@redhat.com> References: <1377081683-1600-1-git-send-email-lersek@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/7] raw_bsd: introduce "special members" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, hch@lst.de, anthony@codemonkey.ws, qemu-devel@nongnu.org On 08/05/13 15:03, Paolo Bonzini wrote: > > [...] > > 3) These members are special > > .format_name is the string "raw" > .bdrv_open raw_open should set bs->sg to bs->file->sg and return 0 > .bdrv_close raw_close should do nothing > .bdrv_probe raw_probe should just return 1. v1->v2: On 08/20/13 10:11, Kevin Wolf wrote: > Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: >> +static int raw_probe(void) >> +{ >> + return 1; >> +} > > Maybe add a comment here like "smallest possible positive score so that > raw is used if and only if no other block driver works". Signed-off-by: Laszlo Ersek --- block/raw_bsd.c | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 5bcbe71..b1d7209 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -112,3 +112,26 @@ static TYPE raw_create(void) { return bdrv_create_file(); } + +static const char *raw_format_name(void) +{ + return "raw"; +} + +static int raw_open(BlockDriverState *bs) +{ + bs->sg = bs->file->sg; + return 0; +} + +static void raw_close(void) +{ +} + +static int raw_probe(void) +{ + /* smallest possible positive score so that raw is used if and only if no + * other block driver works + */ + return 1; +} -- 1.7.1