From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC6Ab-0003Zg-GJ for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:01:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC6AV-0003AU-Gf for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:01:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC6AV-0003AI-9J for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:01:39 -0400 Message-ID: <1377082892.31946.7.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 21 Aug 2013 13:01:32 +0200 In-Reply-To: <0577863ea4bc4e0d91675e4fd250c1065ba4ebd9.1377075625.git.hutao@cn.fujitsu.com> References: <0577863ea4bc4e0d91675e4fd250c1065ba4ebd9.1377075625.git.hutao@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: qemu-devel@nongnu.org Hi, > +#define ICH9_PROC_BASE 0xaf00 > +#define ICH9_PROC_LEN 32 No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff I/O port window to a PCI bridge. Please lets stop occupy random io ports above 0x1000 and burn I/O address space that way. I'd suggest to place it at 0x0a00 instead. Also the dsdt should get a device with the address in _CRS so the guest knows those ports are used. cheers, Gerd