From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VC6is-0004a7-E8
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:37:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VC6il-0007Ya-Fv
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:37:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6386)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1VC6il-0007YR-82
	for qemu-devel@nongnu.org; Wed, 21 Aug 2013 07:37:03 -0400
Message-ID: <1377085017.31946.24.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 21 Aug 2013 13:36:57 +0200
In-Reply-To: <5214A40A.4030409@redhat.com>
References: <d6a33f933ffb550152656e5c7f5b54d43d1c627c.1377075587.git.hutao@cn.fujitsu.com>
	<0577863ea4bc4e0d91675e4fd250c1065ba4ebd9.1377075625.git.hutao@cn.fujitsu.com>
	<1377082892.31946.7.camel@nilsson.home.kraxel.org>
	<5214A40A.4030409@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org

On Mi, 2013-08-21 at 13:27 +0200, Paolo Bonzini wrote:
> Il 21/08/2013 13:01, Gerd Hoffmann ha scritto:
> >   Hi,
> > 
> >> +#define ICH9_PROC_BASE 0xaf00
> >> +#define ICH9_PROC_LEN 32
> > 
> > No, please don't.  It makes it impossible to assign the 0xa000 -> 0xafff
> > I/O port window to a PCI bridge.  Please lets stop occupy random io
> > ports above 0x1000 and burn I/O address space that way.
> > 
> > I'd suggest to place it at 0x0a00 instead.  Also the dsdt should get a
> > device with the address in _CRS so the guest knows those ports are used.
> 
> Would this use 0x0A ("not present, device functional, decoding
> resources") for _STA to "indicate a valid device for which no device
> driver should be loaded" (quoting from the ACPI spec)?  Hopefully this
> prevents Windows from showing the UI.

Sounds reasonable.  Needs careful testing ...

cheers,
  Gerd