From: Alex Bligh <alex@alex.org.uk>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Alex Bligh <alex@alex.org.uk>,
Jan Kiszka <jan.kiszka@siemens.com>,
liu ping fan <qemulist@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>,
rth@twiddle.net
Subject: [Qemu-devel] [PATCHv13 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers
Date: Wed, 21 Aug 2013 16:02:51 +0100 [thread overview]
Message-ID: <1377097389-27335-14-git-send-email-alex@alex.org.uk> (raw)
In-Reply-To: <1377097389-27335-1-git-send-email-alex@alex.org.uk>
Calculate the timeout in aio_ctx_prepare taking into account
the timers attached to the AioContext.
Alter aio_ctx_check similarly.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
async.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/async.c b/async.c
index cff0ab9..5fb3fa6 100644
--- a/async.c
+++ b/async.c
@@ -150,7 +150,10 @@ aio_ctx_prepare(GSource *source, gint *timeout)
{
AioContext *ctx = (AioContext *) source;
QEMUBH *bh;
+ int deadline;
+ /* We assume there is no timeout already supplied */
+ *timeout = -1;
for (bh = ctx->first_bh; bh; bh = bh->next) {
if (!bh->deleted && bh->scheduled) {
if (bh->idle) {
@@ -166,6 +169,14 @@ aio_ctx_prepare(GSource *source, gint *timeout)
}
}
+ deadline = qemu_timeout_ns_to_ms(timerlistgroup_deadline_ns(&ctx->tlg));
+ if (deadline == 0) {
+ *timeout = 0;
+ return true;
+ } else {
+ *timeout = qemu_soonest_timeout(*timeout, deadline);
+ }
+
return false;
}
@@ -180,7 +191,7 @@ aio_ctx_check(GSource *source)
return true;
}
}
- return aio_pending(ctx);
+ return aio_pending(ctx) || (timerlistgroup_deadline_ns(&ctx->tlg) == 0);
}
static gboolean
--
1.7.9.5
next prev parent reply other threads:[~2013-08-21 15:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 15:02 [Qemu-devel] [PATCHv13 00/31] aio / timers: Add AioContext timers and use ppoll Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 01/31] aio / timers: Rename qemu_timer_* functions Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 02/31] aio / timers: Rename qemu_new_clock and expose clock types Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 03/31] aio / timers: add qemu-timer.c utility functions Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 04/31] aio / timers: Consistent treatment of disabled clocks for deadlines Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 05/31] aio / timers: add ppoll support with qemu_poll_ns Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 06/31] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 07/31] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 09/31] aio / timers: Untangle include files Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 10/31] aio / timers: Add QEMUTimerListGroup and helper functions Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 11/31] aio / timers: Add QEMUTimerListGroup to AioContext Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 12/31] aio / timers: Add a notify callback to QEMUTimerList Alex Bligh
2013-08-21 15:02 ` Alex Bligh [this message]
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 14/31] aio / timers: Add aio_timer_init & aio_timer_new wrappers Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 15/31] aio / timers: Convert aio_poll to use AioContext timers' deadline Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 16/31] aio / timers: Convert mainloop to use timeout Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 17/31] aio / timers: On timer modification, qemu_notify or aio_notify Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 18/31] aio / timers: Introduce new API timer_new and friends Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 19/31] aio / timers: Use all timerlists in icount warp calculations Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 20/31] aio / timers: Add documentation and new format calls Alex Bligh
2013-08-21 15:02 ` [Qemu-devel] [PATCHv13 21/31] aio / timers: Remove alarm timers Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 22/31] aio / timers: Remove legacy qemu_clock_deadline & qemu_timerlist_deadline Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 23/31] aio / timers: Add qemu_clock_get_ms and qemu_clock_get_ms Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 24/31] aio / timers: Rearrange timer.h & make legacy functions call non-legacy Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 25/31] aio / timers: Remove main_loop_timerlist Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 26/31] aio / timers: Convert rtc_clock to be a QEMUClockType Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 27/31] aio / timers: convert block_job_sleep_ns and co_sleep_ns to new API Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 28/31] aio / timers: Add test harness for AioContext timers Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 29/31] aio / timers: Add scripts/switch-timer-api Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 30/31] aio / timers: Switch entire codebase to the new timer API Alex Bligh
2013-08-21 15:03 ` [Qemu-devel] [PATCHv13 31/31] aio / timers: Remove legacy interface Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377097389-27335-14-git-send-email-alex@alex.org.uk \
--to=alex@alex.org.uk \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).