From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Paolo Bonzini <pbonzini@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH v3 2/3] vfio: Fix debug output for int128 values
Date: Thu, 22 Aug 2013 21:29:24 +1000 [thread overview]
Message-ID: <1377170965-9905-3-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1377170965-9905-1-git-send-email-aik@ozlabs.ru>
Memory regions can easily be 2^64 byte long and therefore overflow
for just a bit but that is enough for int128_get64() to assert.
This takes care of debug printing of huge section sizes.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/misc/vfio.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 017e693..dfe3a80 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -1928,7 +1928,8 @@ static void vfio_listener_region_add(MemoryListener *listener,
if (vfio_listener_skipped_section(section)) {
DPRINTF("SKIPPING region_add %"HWADDR_PRIx" - %"PRIx64"\n",
section->offset_within_address_space,
- section->offset_within_address_space + section->size - 1);
+ section->offset_within_address_space +
+ int128_get64(int128_sub(section->size, int128_one())));
return;
}
@@ -1973,7 +1974,8 @@ static void vfio_listener_region_del(MemoryListener *listener,
if (vfio_listener_skipped_section(section)) {
DPRINTF("SKIPPING region_del %"HWADDR_PRIx" - %"PRIx64"\n",
section->offset_within_address_space,
- section->offset_within_address_space + section->size - 1);
+ section->offset_within_address_space +
+ int128_get64(int128_sub(section->size, int128_one())));
return;
}
--
1.8.4.rc4
next prev parent reply other threads:[~2013-08-22 11:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 11:29 [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 1/3] int128: add int128_exts64() Alexey Kardashevskiy
2013-08-22 11:29 ` Alexey Kardashevskiy [this message]
2013-08-22 11:29 ` [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling Alexey Kardashevskiy
2013-08-28 15:18 ` Alex Williamson
2013-08-29 1:03 ` Alexey Kardashevskiy
2013-08-29 1:42 ` Alex Williamson
2013-08-29 2:26 ` Alexey Kardashevskiy
2013-08-29 6:29 ` Paolo Bonzini
2013-08-29 6:58 ` Alexey Kardashevskiy
2013-08-29 8:50 ` Paolo Bonzini
2013-08-30 6:15 ` Alexey Kardashevskiy
2013-08-30 6:39 ` Paolo Bonzini
2013-08-30 6:42 ` Alexey Kardashevskiy
2013-08-28 9:46 ` [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes Alexey Kardashevskiy
2013-08-28 11:09 ` Paolo Bonzini
2013-08-28 14:10 ` Alex Williamson
2013-08-28 14:29 ` Paolo Bonzini
2013-09-10 4:23 ` Alexey Kardashevskiy
2013-09-10 6:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377170965-9905-3-git-send-email-aik@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).