qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, Marcel Apfelbaum <marcel.a@redhat.com>,
	mst@redhat.com, armbru@redhat.com, pbonzini@redhat.com,
	afaerber@suse.de
Subject: [Qemu-devel]  [PATCH ] qemu-help: add category headlines
Date: Thu, 22 Aug 2013 15:48:20 +0300	[thread overview]
Message-ID: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> (raw)

This patch follows Markus Armbruster suggestion:

A possibly better way to group help by category: instead of adding
categories to each line, add category headlines, like this:

    Controller/Bridge/Hub devices:
    name "NAME", bus "BUS"...
    ...
    USB devices:
    name "NAME", bus "BUS"...
    ...
    Storage devices:
    ...

This way, showing devices with multiple categories once per category
actually makes sense.

Note that the "categories to each line" is kept for 2 reasons:
1. Preparation for multifunction devices
2. Ability to grep by category

Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
 qdev-monitor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qdev-monitor.c b/qdev-monitor.c
index 410cdcb..a7329b0 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory category)
     DeviceClass *dc;
     GSList *list, *curr;
 
+    error_printf("%s devices:\n", qdev_category_get_name(category));
+
     list = object_class_get_list(TYPE_DEVICE, false);
     for (curr = list; curr; curr = g_slist_next(curr)) {
         dc = (DeviceClass *)object_class_dynamic_cast(curr->data, TYPE_DEVICE);
-- 
1.8.3.1

             reply	other threads:[~2013-08-22 12:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 12:48 Marcel Apfelbaum [this message]
2013-08-22 14:00 ` [Qemu-devel] [PATCH ] qemu-help: add category headlines Andreas Färber
2013-08-22 14:13   ` Markus Armbruster
2013-08-22 15:34     ` Eric Blake
2013-08-22 17:18       ` Marcel Apfelbaum
2013-08-22 17:47         ` Markus Armbruster
2013-08-28  8:10 ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377175700-16229-1-git-send-email-marcel.a@redhat.com \
    --to=marcel.a@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).