From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCUJW-0007OY-2y for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCUJN-0008Ka-If for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:48:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCUJN-0008J3-BL for qemu-devel@nongnu.org; Thu, 22 Aug 2013 08:48:25 -0400 From: Marcel Apfelbaum Date: Thu, 22 Aug 2013 15:48:20 +0300 Message-Id: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> Subject: [Qemu-devel] [PATCH ] qemu-help: add category headlines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, Marcel Apfelbaum , mst@redhat.com, armbru@redhat.com, pbonzini@redhat.com, afaerber@suse.de This patch follows Markus Armbruster suggestion: A possibly better way to group help by category: instead of adding categories to each line, add category headlines, like this: Controller/Bridge/Hub devices: name "NAME", bus "BUS"... ... USB devices: name "NAME", bus "BUS"... ... Storage devices: ... This way, showing devices with multiple categories once per category actually makes sense. Note that the "categories to each line" is kept for 2 reasons: 1. Preparation for multifunction devices 2. Ability to grep by category Signed-off-by: Marcel Apfelbaum --- qdev-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qdev-monitor.c b/qdev-monitor.c index 410cdcb..a7329b0 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory category) DeviceClass *dc; GSList *list, *curr; + error_printf("%s devices:\n", qdev_category_get_name(category)); + list = object_class_get_list(TYPE_DEVICE, false); for (curr = list; curr; curr = g_slist_next(curr)) { dc = (DeviceClass *)object_class_dynamic_cast(curr->data, TYPE_DEVICE); -- 1.8.3.1