qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v3] usb/dev-hid: Modified usb-tablet category from Misc to Input
@ 2013-08-22 13:44 Marcel Apfelbaum
  2013-08-25  9:53 ` Michael S. Tsirkin
  0 siblings, 1 reply; 2+ messages in thread
From: Marcel Apfelbaum @ 2013-08-22 13:44 UTC (permalink / raw)
  To: qemu-devel
  Cc: aliguori, mst, Marcel Apfelbaum, armbru, qemu-stable, kraxel,
	pbonzini, afaerber

usb-tablet device was wrongly assigned to Misc category

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
---
Changes from v2:
 - Corrected spelling
Changes from v1:
 - Add cc to qemu-stable and Gerd Hoffmann
 - Changed subject prefix from hw to usb/dev-hid

 hw/usb/dev-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index 66c6331..5956720 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
     uc->product_desc   = "QEMU USB Tablet";
     dc->vmsd = &vmstate_usb_ptr;
     dc->props = usb_tablet_properties;
-    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
 }
 
 static const TypeInfo usb_tablet_info = {
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH v3] usb/dev-hid: Modified usb-tablet category from Misc to Input
  2013-08-22 13:44 [Qemu-devel] [PATCH v3] usb/dev-hid: Modified usb-tablet category from Misc to Input Marcel Apfelbaum
@ 2013-08-25  9:53 ` Michael S. Tsirkin
  0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2013-08-25  9:53 UTC (permalink / raw)
  To: Marcel Apfelbaum
  Cc: aliguori, armbru, qemu-stable, qemu-devel, kraxel, pbonzini,
	afaerber

On Thu, Aug 22, 2013 at 04:44:11PM +0300, Marcel Apfelbaum wrote:
> usb-tablet device was wrongly assigned to Misc category
> 
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> Changes from v2:
>  - Corrected spelling
> Changes from v1:
>  - Add cc to qemu-stable and Gerd Hoffmann
>  - Changed subject prefix from hw to usb/dev-hid
> 
>  hw/usb/dev-hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
> index 66c6331..5956720 100644
> --- a/hw/usb/dev-hid.c
> +++ b/hw/usb/dev-hid.c
> @@ -658,7 +658,7 @@ static void usb_tablet_class_initfn(ObjectClass *klass, void *data)
>      uc->product_desc   = "QEMU USB Tablet";
>      dc->vmsd = &vmstate_usb_ptr;
>      dc->props = usb_tablet_properties;
> -    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>  
>  static const TypeInfo usb_tablet_info = {
> -- 
> 1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-25  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 13:44 [Qemu-devel] [PATCH v3] usb/dev-hid: Modified usb-tablet category from Misc to Input Marcel Apfelbaum
2013-08-25  9:53 ` Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).