* [Qemu-devel] [PATCH] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c
@ 2013-08-22 18:59 Alex Bligh
2013-08-22 20:03 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bligh @ 2013-08-22 18:59 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Anthony Liguori, Alex Bligh, Jan Kiszka, liu ping fan,
Stefan Hajnoczi, Paolo Bonzini, MORITA Kazutaka, rth
Remove dummy_io_handler_flush from tests/test-aio.c as it does
nothing now.
Signed-off-by: Alex Bligh <alex@alex.org.uk>
---
tests/test-aio.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/tests/test-aio.c b/tests/test-aio.c
index 3ad2294..07a1f61 100644
--- a/tests/test-aio.c
+++ b/tests/test-aio.c
@@ -77,11 +77,6 @@ static void dummy_io_handler_read(void *opaque)
{
}
-static int dummy_io_handler_flush(void *opaque)
-{
- return 1;
-}
-
static void bh_delete_cb(void *opaque)
{
BHTestData *data = opaque;
@@ -382,7 +377,7 @@ static void test_timer_schedule(void)
*/
g_assert(!pipe2(pipefd, O_NONBLOCK));
aio_set_fd_handler(ctx, pipefd[0],
- dummy_io_handler_read, NULL, dummy_io_handler_flush);
+ dummy_io_handler_read, NULL, NULL);
aio_poll(ctx, false);
aio_timer_init(ctx, &data.timer, data.clock_type,
@@ -723,7 +718,7 @@ static void test_source_timer_schedule(void)
*/
g_assert(!pipe2(pipefd, O_NONBLOCK));
aio_set_fd_handler(ctx, pipefd[0],
- dummy_io_handler_read, NULL, dummy_io_handler_flush);
+ dummy_io_handler_read, NULL, NULL);
do {} while (g_main_context_iteration(NULL, false));
aio_timer_init(ctx, &data.timer, data.clock_type,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c
2013-08-22 18:59 [Qemu-devel] [PATCH] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c Alex Bligh
@ 2013-08-22 20:03 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-08-22 20:03 UTC (permalink / raw)
To: Alex Bligh
Cc: Kevin Wolf, Anthony Liguori, Jan Kiszka, qemu-devel, liu ping fan,
Stefan Hajnoczi, Paolo Bonzini, MORITA Kazutaka, rth
On Thu, Aug 22, 2013 at 07:59:16PM +0100, Alex Bligh wrote:
> Remove dummy_io_handler_flush from tests/test-aio.c as it does
> nothing now.
>
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
> tests/test-aio.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-22 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 18:59 [Qemu-devel] [PATCH] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c Alex Bligh
2013-08-22 20:03 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).