qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	Alex Bligh <alex@alex.org.uk>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PULL 15/42] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress
Date: Thu, 22 Aug 2013 22:11:11 +0200	[thread overview]
Message-ID: <1377202298-22896-16-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1377202298-22896-1-git-send-email-stefanha@redhat.com>

From: Alex Bligh <alex@alex.org.uk>

Make qemu_run_timers and qemu_run_all_timers return progress
so that aio_poll etc. can determine whether a timer has been
run.

Signed-off-by: Alex Bligh <alex@alex.org.uk>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/qemu/timer.h | 21 +++++++++++++++++++--
 qemu-timer.c         | 18 ++++++++++++------
 2 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/include/qemu/timer.h b/include/qemu/timer.h
index e4a6479..962eca8 100644
--- a/include/qemu/timer.h
+++ b/include/qemu/timer.h
@@ -92,8 +92,25 @@ bool timer_pending(QEMUTimer *ts);
 bool timer_expired(QEMUTimer *timer_head, int64_t current_time);
 uint64_t timer_expire_time_ns(QEMUTimer *ts);
 
-void qemu_run_timers(QEMUClock *clock);
-void qemu_run_all_timers(void);
+/**
+ * qemu_run_timers:
+ * @clock: clock on which to operate
+ *
+ * Run all the timers associated with a clock.
+ *
+ * Returns: true if any timer ran.
+ */
+bool qemu_run_timers(QEMUClock *clock);
+
+/**
+ * qemu_run_all_timers:
+ *
+ * Run all the timers associated with every clock.
+ *
+ * Returns: true if any timer ran.
+ */
+bool qemu_run_all_timers(void);
+
 void configure_alarms(char const *opt);
 void init_clocks(void);
 int init_timer_alarm(void);
diff --git a/qemu-timer.c b/qemu-timer.c
index 74f904b..52a1947 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -446,13 +446,14 @@ bool timer_expired(QEMUTimer *timer_head, int64_t current_time)
     return timer_expired_ns(timer_head, current_time * timer_head->scale);
 }
 
-void qemu_run_timers(QEMUClock *clock)
+bool qemu_run_timers(QEMUClock *clock)
 {
     QEMUTimer *ts;
     int64_t current_time;
+    bool progress = false;
    
     if (!clock->enabled)
-        return;
+        return progress;
 
     current_time = qemu_get_clock_ns(clock);
     for(;;) {
@@ -466,7 +467,9 @@ void qemu_run_timers(QEMUClock *clock)
 
         /* run the callback (the timer list can be modified) */
         ts->cb(ts->opaque);
+        progress = true;
     }
+    return progress;
 }
 
 int64_t qemu_get_clock_ns(QEMUClock *clock)
@@ -521,20 +524,23 @@ uint64_t timer_expire_time_ns(QEMUTimer *ts)
     return timer_pending(ts) ? ts->expire_time : -1;
 }
 
-void qemu_run_all_timers(void)
+bool qemu_run_all_timers(void)
 {
+    bool progress = false;
     alarm_timer->pending = false;
 
     /* vm time timers */
-    qemu_run_timers(vm_clock);
-    qemu_run_timers(rt_clock);
-    qemu_run_timers(host_clock);
+    progress |= qemu_run_timers(vm_clock);
+    progress |= qemu_run_timers(rt_clock);
+    progress |= qemu_run_timers(host_clock);
 
     /* rearm timer, if not periodic */
     if (alarm_timer->expired) {
         alarm_timer->expired = false;
         qemu_rearm_alarm_timer(alarm_timer);
     }
+
+    return progress;
 }
 
 #ifdef _WIN32
-- 
1.8.3.1

  parent reply	other threads:[~2013-08-22 20:12 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 20:10 [Qemu-devel] [PULL 00/42] Block patches Stefan Hajnoczi
2013-08-22 20:10 ` [Qemu-devel] [PULL 01/42] qcow2: Change default for new images to compat=1.1 Stefan Hajnoczi
2013-08-22 20:10 ` [Qemu-devel] [PULL 02/42] block: Introduce bs->zero_beyond_eof Stefan Hajnoczi
2013-08-22 20:10 ` [Qemu-devel] [PULL 03/42] block: Produce zeros when protocols reading beyond end of file Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 04/42] block: better error message for read only format name Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 05/42] vmdk: Move l1_size check into vmdk_add_extent() Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 06/42] vmdk: fix L1 and L2 table size in vmdk3 open Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 07/42] vmdk: support vmfsSparse files Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 08/42] vmdk: support vmfs files Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 09/42] aio / timers: Rename qemu_timer_* functions Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 10/42] aio / timers: Rename qemu_new_clock and expose clock types Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 11/42] aio / timers: add qemu-timer.c utility functions Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 12/42] aio / timers: Consistent treatment of disabled clocks for deadlines Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 13/42] aio / timers: add ppoll support with qemu_poll_ns Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 14/42] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack Stefan Hajnoczi
2013-08-22 20:11 ` Stefan Hajnoczi [this message]
2013-08-22 20:11 ` [Qemu-devel] [PULL 16/42] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 17/42] aio / timers: Untangle include files Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 18/42] aio / timers: Add QEMUTimerListGroup and helper functions Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 19/42] aio / timers: Add QEMUTimerListGroup to AioContext Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 20/42] aio / timers: Add a notify callback to QEMUTimerList Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 21/42] aio / timers: aio_ctx_prepare sets timeout from AioContext timers Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 22/42] aio / timers: Add aio_timer_init & aio_timer_new wrappers Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 23/42] aio / timers: Convert aio_poll to use AioContext timers' deadline Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 24/42] aio / timers: Convert mainloop to use timeout Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 25/42] aio / timers: On timer modification, qemu_notify or aio_notify Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 26/42] aio / timers: Introduce new API timer_new and friends Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 27/42] aio / timers: Use all timerlists in icount warp calculations Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 28/42] aio / timers: Add documentation and new format calls Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 29/42] aio / timers: Remove alarm timers Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 30/42] aio / timers: Remove legacy qemu_clock_deadline & qemu_timerlist_deadline Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 31/42] aio / timers: Add qemu_clock_get_ms and qemu_clock_get_ms Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 32/42] aio / timers: Rearrange timer.h & make legacy functions call non-legacy Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 33/42] aio / timers: Remove main_loop_timerlist Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 34/42] aio / timers: Convert rtc_clock to be a QEMUClockType Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 35/42] aio / timers: convert block_job_sleep_ns and co_sleep_ns to new API Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 36/42] aio / timers: Add test harness for AioContext timers Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 37/42] aio / timers: Add scripts/switch-timer-api Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 38/42] aio / timers: Switch entire codebase to the new timer API Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 39/42] aio / timers: Remove legacy interface Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 40/42] aio / timers: remove dummy_io_handler_flush from tests/test-aio.c Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 41/42] aio-win32: replace incorrect AioHandler->opaque usage with ->e Stefan Hajnoczi
2013-08-22 20:11 ` [Qemu-devel] [PULL 42/42] win32-aio: drop win32_aio_flush_cb() Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377202298-22896-16-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=alex@alex.org.uk \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).