From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com,
xiawenc@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v6 0/8] Implement reference count for BlockDriverState
Date: Fri, 23 Aug 2013 09:14:43 +0800 [thread overview]
Message-ID: <1377220491-19954-1-git-send-email-famz@redhat.com> (raw)
BlockDriverState lifecycle management is needed by future features such as
image fleecing and blockdev-add. This series adds reference count to
BlockDriverState.
The first two patches clean up two odd BlockDriverState use cases, so all code
uses bdrv_new() to create BlockDriverState instance.
Then implemented bdrv_ref() and bdrv_unref() to operate on refcnt: Initially,
refcnt is 1, which means bdrv_unref is effectively a bdrv_delete() here. So
patch 04 has a search and replace to convert bdrv_delete to bdrv_unref, before
bdrv_ref is used anywhere. 05~08 patches calls bdrv_ref for device attach,
block-migration and nbd.
The rule is: Either bdrv_ref() or bdrv_new() must have a matching
bdrv_unref() call, and the last matching bdrv_unref deletes the bs.
v6:
08: Use BH to release reference, this fixes the iotest.
v5: resend v4 to a right list.
v4:
08: Added, let block job use BDS reference.
02: Fix leak of bs.opaque
v3:
03: Removed unnecessary bdrv_close() call.
v2:
05: Removed: "block: use BlockDriverState refcnt for device attach/detach"
07: Fix xen_disk blk_disconnect() as it depended on device attach refcnt.
Fam Zheng (8):
vvfat: use bdrv_new() to allocate BlockDriverState
iscsi: use bdrv_new() instead of stack structure
block: implement reference count for BlockDriverState
block: make bdrv_delete() static
migration: omit drive ref as we have bdrv_ref now
xen_disk: simplify blk_disconnect with refcnt
nbd: use BlockDriverState refcnt
block: use BDS ref for block jobs
block-migration.c | 4 +--
block.c | 44 ++++++++++++++++++++++++---------
block/backup.c | 2 +-
block/blkverify.c | 4 +--
block/cow.c | 2 +-
block/iscsi.c | 16 ++++++------
block/mirror.c | 2 +-
block/qcow.c | 2 +-
block/qcow2.c | 2 +-
block/qed.c | 2 +-
block/sheepdog.c | 6 ++---
block/snapshot.c | 2 +-
block/stream.c | 2 +-
block/vmdk.c | 10 ++++----
block/vvfat.c | 6 ++---
blockdev-nbd.c | 10 +-------
blockdev.c | 63 +++++++++++++++++------------------------------
blockjob.c | 1 +
hw/block/xen_disk.c | 13 +++++-----
include/block/block.h | 3 ++-
include/block/block_int.h | 1 +
nbd.c | 5 ++++
qemu-img.c | 26 +++++++++----------
qemu-io.c | 6 ++---
24 files changed, 119 insertions(+), 115 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-08-23 1:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 1:14 Fam Zheng [this message]
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 1/8] vvfat: use bdrv_new() to allocate BlockDriverState Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 2/8] iscsi: use bdrv_new() instead of stack structure Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 3/8] block: implement reference count for BlockDriverState Fam Zheng
2013-08-23 16:12 ` Jeff Cody
2013-08-26 1:15 ` Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 4/8] block: make bdrv_delete() static Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 5/8] migration: omit drive ref as we have bdrv_ref now Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 6/8] xen_disk: simplify blk_disconnect with refcnt Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 7/8] nbd: use BlockDriverState refcnt Fam Zheng
2013-08-23 1:14 ` [Qemu-devel] [PATCH v6 8/8] block: use BDS ref for block jobs Fam Zheng
2013-09-04 13:52 ` [Qemu-devel] [PATCH v6 0/8] Implement reference count for BlockDriverState Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377220491-19954-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).