From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCmbR-0005li-Cj for qemu-devel@nongnu.org; Fri, 23 Aug 2013 04:20:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCmbH-0007R0-Hd for qemu-devel@nongnu.org; Fri, 23 Aug 2013 04:20:17 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:58645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCmbG-0007PK-SO for qemu-devel@nongnu.org; Fri, 23 Aug 2013 04:20:07 -0400 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Aug 2013 13:42:03 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 328D6394004D for ; Fri, 23 Aug 2013 13:49:52 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7N8LY8X35520728 for ; Fri, 23 Aug 2013 13:51:34 +0530 Received: from d28av05.in.ibm.com (localhost [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7N8K1P7007148 for ; Fri, 23 Aug 2013 13:50:01 +0530 From: Wenchao Xia Date: Fri, 23 Aug 2013 16:17:58 +0800 Message-Id: <1377245887-22745-7-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1377245887-22745-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1377245887-22745-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V9 06/15] monitor: call sortcmdlist() only one time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Wenchao Xia , armbru@redhat.com, lcapitulino@redhat.com It doesn't need to be done for every monitor, so change it. Signed-off-by: Wenchao Xia --- monitor.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 63a779f..bf019e2 100644 --- a/monitor.c +++ b/monitor.c @@ -4762,6 +4762,7 @@ void monitor_init(CharDriverState *chr, int flags) if (is_first_init) { monitor_protocol_event_init(); + sortcmdlist(); is_first_init = 0; } @@ -4791,8 +4792,6 @@ void monitor_init(CharDriverState *chr, int flags) QLIST_INSERT_HEAD(&mon_list, mon, entry); if (!default_mon || (flags & MONITOR_IS_DEFAULT)) default_mon = mon; - - sortcmdlist(); } static void bdrv_password_cb(Monitor *mon, const char *password, void *opaque) -- 1.7.1