From: Gerd Hoffmann <kraxel@redhat.com>
To: "Ákos Kovács" <akoskovacs@gmx.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] Patchset description
Date: Fri, 23 Aug 2013 12:32:14 +0200 [thread overview]
Message-ID: <1377253934.5596.4.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1377220732-24198-1-git-send-email-akoskovacs@gmx.com>
On Fr, 2013-08-23 at 03:18 +0200, Ákos Kovács wrote:
> Patch 1: Move sysbus and PCI specific code to a new files from hw/usb/hcd-ohci.c.
Looks good, except that it breaks ohci due to not compiling the new
files.
> Patch 2: Make them new configuration variables *_OHCI_SYSBUS and *_OHCI_PCI and add
> them to the arm and sh4 default configuration.
>
> Patch 3: Create similar configuration variables for hcd-uhci-sysbus.c and hcd-uhci-pci.c as
> *_UHCI_SYSBUS and *_UHCI_PCI.
Hmm, I think doing this fine-grained config should wait until we have
Kconfig, so we can create proper dependencies for this.
cheers,
Gerd
prev parent reply other threads:[~2013-08-23 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 1:18 [Qemu-devel] [PATCH 0/3] Patchset description Ákos Kovács
2013-08-23 1:18 ` [Qemu-devel] [PATCH 1/3] hw/usb/hcd-ohci.c: Move sysbus and PCI code to new files Ákos Kovács
2013-08-23 11:26 ` Andreas Färber
2013-08-23 1:18 ` [Qemu-devel] [PATCH 2/3] hw/usb/Makefile.objs: Make config options for ohci-pci Ákos Kovács
2013-08-23 1:18 ` [Qemu-devel] [PATCH 3/3] Makefile.objs: Split CONFIG_USB_EHCI Ákos Kovács
2013-08-23 10:32 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377253934.5596.4.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=akoskovacs@gmx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).