* [Qemu-devel] [PATCH v2] migration: Fix debug print type
@ 2013-08-23 17:34 Christoffer Dall
2013-08-23 18:47 ` Stefan Weil
2013-09-24 8:26 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: Christoffer Dall @ 2013-08-23 17:34 UTC (permalink / raw)
To: qemu-devel; +Cc: linaro-kernel, kvmarm, Christoffer Dall, patches
The printf args are uint64_t and with -Werr QEMU doesn't compile with
migration debugging turned on unless this is fixed. Fix it.
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
[Changelog v1 -> v2]:
- Use PRIu64 instead of %llu
migration.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 1402fa7..e9b83f6 100644
--- a/migration.c
+++ b/migration.c
@@ -566,7 +566,8 @@ static void *migration_thread(void *opaque)
if (!qemu_file_rate_limit(s->file)) {
DPRINTF("iterate\n");
pending_size = qemu_savevm_state_pending(s->file, max_size);
- DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
+ DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n",
+ pending_size, max_size);
if (pending_size && pending_size >= max_size) {
qemu_savevm_state_iterate(s->file);
} else {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] migration: Fix debug print type
2013-08-23 17:34 [Qemu-devel] [PATCH v2] migration: Fix debug print type Christoffer Dall
@ 2013-08-23 18:47 ` Stefan Weil
2013-09-24 8:26 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2013-08-23 18:47 UTC (permalink / raw)
To: Christoffer Dall; +Cc: qemu-trivial, linaro-kernel, qemu-devel, patches, kvmarm
Am 23.08.2013 19:34, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed. Fix it.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
>
> [Changelog v1 -> v2]:
> - Use PRIu64 instead of %llu
>
> migration.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/migration.c b/migration.c
> index 1402fa7..e9b83f6 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -566,7 +566,8 @@ static void *migration_thread(void *opaque)
> if (!qemu_file_rate_limit(s->file)) {
> DPRINTF("iterate\n");
> pending_size = qemu_savevm_state_pending(s->file, max_size);
> - DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
> + DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n",
> + pending_size, max_size);
> if (pending_size && pending_size >= max_size) {
> qemu_savevm_state_iterate(s->file);
> } else {
Reviewed-by: Stefan Weil <sw@weilnetz.de>
max_size is not uint64_t but int64_t, so PRId64 would be even better
for that argument, but I don't think this is worth an additional iteration.
CC'ing qemu-trivial, the patch can be applied there.
Regards,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2] migration: Fix debug print type
2013-08-23 17:34 [Qemu-devel] [PATCH v2] migration: Fix debug print type Christoffer Dall
2013-08-23 18:47 ` Stefan Weil
@ 2013-09-24 8:26 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2013-09-24 8:26 UTC (permalink / raw)
To: Christoffer Dall; +Cc: linaro-kernel, qemu-devel, patches, kvmarm
Christoffer Dall <christoffer.dall@linaro.org> wrote:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed. Fix it.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-24 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 17:34 [Qemu-devel] [PATCH v2] migration: Fix debug print type Christoffer Dall
2013-08-23 18:47 ` Stefan Weil
2013-09-24 8:26 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).