From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 1/3] pci: remove explicit check to 64K ioport size
Date: Fri, 23 Aug 2013 20:52:51 +0200 [thread overview]
Message-ID: <1377283973-9320-2-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1377283973-9320-1-git-send-email-hpoussin@reactos.org>
This check is useless, as bigger addresses will be ignored when
added to 'io' MemoryRegion, which has a size of 64K.
However, on architectures which have memory-mapped I/O, PCI I/O BARs
can be mapped to an I/O address which is bigger than 64K.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/pci/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4c004f5..54cd43d 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1033,8 +1033,7 @@ static pcibus_t pci_bar_address(PCIDevice *d,
}
new_addr = pci_get_long(d->config + bar) & ~(size - 1);
last_addr = new_addr + size - 1;
- /* NOTE: we have only 64K ioports on PC */
- if (last_addr <= new_addr || new_addr == 0 || last_addr > UINT16_MAX) {
+ if (last_addr <= new_addr || new_addr == 0) {
return PCI_BAR_UNMAPPED;
}
return new_addr;
--
1.7.10.4
next prev parent reply other threads:[~2013-08-23 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 18:52 [Qemu-devel] [PATCH 0/3] prep: improve Raven PCI host emulation Hervé Poussineau
2013-08-23 18:52 ` Hervé Poussineau [this message]
2013-08-23 18:52 ` [Qemu-devel] [PATCH 2/3] prep: kill get_system_io() usage Hervé Poussineau
2013-08-23 18:52 ` [Qemu-devel] [PATCH 3/3] prep: improve Raven PCI host emulation Hervé Poussineau
2013-08-23 19:56 ` Richard Henderson
2013-09-02 20:26 ` Hervé Poussineau
2013-09-02 20:48 ` Peter Maydell
2013-09-02 20:59 ` Peter Maydell
2013-09-02 21:18 ` Hervé Poussineau
2013-09-02 21:34 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377283973-9320-2-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).