From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSa-0002NJ-4F for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCwSU-0002Ua-JR for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:48 -0400 Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:48897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSU-0002Tw-0Q for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:42 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Fri, 23 Aug 2013 20:52:51 +0200 Message-Id: <1377283973-9320-2-git-send-email-hpoussin@reactos.org> In-Reply-To: <1377283973-9320-1-git-send-email-hpoussin@reactos.org> References: <1377283973-9320-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/3] pci: remove explicit check to 64K ioport size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , "Michael S . Tsirkin" This check is useless, as bigger addresses will be ignored when added to 'io' MemoryRegion, which has a size of 64K. However, on architectures which have memory-mapped I/O, PCI I/O BARs can be mapped to an I/O address which is bigger than 64K. Signed-off-by: Herv=C3=A9 Poussineau --- hw/pci/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4c004f5..54cd43d 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1033,8 +1033,7 @@ static pcibus_t pci_bar_address(PCIDevice *d, } new_addr =3D pci_get_long(d->config + bar) & ~(size - 1); last_addr =3D new_addr + size - 1; - /* NOTE: we have only 64K ioports on PC */ - if (last_addr <=3D new_addr || new_addr =3D=3D 0 || last_addr > = UINT16_MAX) { + if (last_addr <=3D new_addr || new_addr =3D=3D 0) { return PCI_BAR_UNMAPPED; } return new_addr; --=20 1.7.10.4