From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSh-0002Oc-Dn for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCwSb-0002XA-Td for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:55 -0400 Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:49412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSb-0002W8-AW for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:49 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Fri, 23 Aug 2013 20:52:52 +0200 Message-Id: <1377283973-9320-3-git-send-email-hpoussin@reactos.org> In-Reply-To: <1377283973-9320-1-git-send-email-hpoussin@reactos.org> References: <1377283973-9320-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 2/3] prep: kill get_system_io() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= While ISA address space in prep machine is currently the one returned by get_system_io(), this depends of the implementation of i82378/raven devices, and this may not be the case forever. Use the right ISA address space when adding some more ports to it. We can use whatever ISA device on the right ISA bus, as all ISA devices on the same ISA bus share the same ISA address space. Signed-off-by: Herv=C3=A9 Poussineau --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 7e04b1a..efc892d 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -656,7 +656,7 @@ static void ppc_prep_init(QEMUMachineInitArgs *args) sysctrl->reset_irq =3D cpu->env.irq_inputs[PPC6xx_INPUT_HRESET]; =20 portio_list_init(port_list, NULL, prep_portio_list, sysctrl, "prep")= ; - portio_list_add(port_list, get_system_io(), 0x0); + portio_list_add(port_list, isa_address_space_io(isa), 0x0); =20 /* PowerPC control and status register group */ #if 0 --=20 1.7.10.4