From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCxh3-0002pu-0y for qemu-devel@nongnu.org; Fri, 23 Aug 2013 16:10:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCxgw-0005y8-0r for qemu-devel@nongnu.org; Fri, 23 Aug 2013 16:10:48 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:42771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCxgv-0005xi-Ko for qemu-devel@nongnu.org; Fri, 23 Aug 2013 16:10:41 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb10so1088759pad.9 for ; Fri, 23 Aug 2013 13:10:41 -0700 (PDT) From: Christoffer Dall Date: Fri, 23 Aug 2013 13:10:23 -0700 Message-Id: <1377288624-7418-5-git-send-email-christoffer.dall@linaro.org> In-Reply-To: <1377288624-7418-1-git-send-email-christoffer.dall@linaro.org> References: <1377288624-7418-1-git-send-email-christoffer.dall@linaro.org> Subject: [Qemu-devel] [PATCH 4/5] hw: arm_gic: Support setting/getting binary point reg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: linaro-kernel@lists.linaro.org, kvmarm@lists.cs.columbia.edu, Christoffer Dall , patches@linaro.org Add a binary_point field to the gic emulation structure and support setting/getting this register now when we have it. We don't actually support interrupt grouping yet, oh well. Signed-off-by: Christoffer Dall --- hw/intc/arm_gic.c | 5 ++--- hw/intc/arm_gic_common.c | 1 + hw/intc/gic_internal.h | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index 4da534f..cb2004d 100644 --- a/hw/intc/arm_gic.c +++ b/hw/intc/arm_gic.c @@ -568,8 +568,7 @@ static uint32_t gic_cpu_read(GICState *s, int cpu, int offset) case 0x04: /* Priority mask */ return s->priority_mask[cpu]; case 0x08: /* Binary Point */ - /* ??? Not implemented. */ - return 0; + return s->binary_point[0][cpu]; case 0x0c: /* Acknowledge */ value = gic_acknowledge_irq(s, cpu); value |= (GIC_SGI_SRC(value, cpu) & 0x7) << 10; @@ -596,7 +595,7 @@ static void gic_cpu_write(GICState *s, int cpu, int offset, uint32_t value) s->priority_mask[cpu] = (value & 0xff); break; case 0x08: /* Binary Point */ - /* ??? Not implemented. */ + s->binary_point[0][cpu] = (value & 0x7); break; case 0x10: /* End Of Interrupt */ return gic_complete_irq(s, cpu, value & 0x3ff); diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c index 7a1c9e5..a50ded2 100644 --- a/hw/intc/arm_gic_common.c +++ b/hw/intc/arm_gic_common.c @@ -76,6 +76,7 @@ static const VMStateDescription vmstate_gic = { VMSTATE_UINT16_ARRAY(running_irq, GICState, NCPU), VMSTATE_UINT16_ARRAY(running_priority, GICState, NCPU), VMSTATE_UINT16_ARRAY(current_pending, GICState, NCPU), + VMSTATE_UINT8_2DARRAY(binary_point, GICState, 2, NCPU), VMSTATE_END_OF_LIST() } }; diff --git a/hw/intc/gic_internal.h b/hw/intc/gic_internal.h index 6f04885..424a41f 100644 --- a/hw/intc/gic_internal.h +++ b/hw/intc/gic_internal.h @@ -98,6 +98,9 @@ typedef struct GICState { uint16_t running_priority[NCPU]; uint16_t current_pending[NCPU]; + /* these registers are mainly used for save/restore of KVM state */ + uint8_t binary_point[2][NCPU]; /* [0]: group 0, [1]: group 1 */ + uint32_t num_cpu; MemoryRegion iomem; /* Distributor */ -- 1.7.10.4