From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
patches@linaro.org, Anthony Liguori <anthony@codemonkey.ws>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 5/9] bswap.h: Remove be32_to_cpupu()
Date: Sun, 25 Aug 2013 15:59:33 +0100 [thread overview]
Message-ID: <1377442777-11066-6-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1377442777-11066-1-git-send-email-peter.maydell@linaro.org>
Replace the legacy be32_to_cpupu() with ldl_be_p().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/net/e1000.c | 2 +-
include/qemu/bswap.h | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index fdb1f89..f770f08 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -526,7 +526,7 @@ xmit_seg(E1000State *s)
if (tp->tcp) {
sofar = frames * tp->mss;
cpu_to_be32wu((uint32_t *)(tp->data+css+4), // seq
- be32_to_cpupu((uint32_t *)(tp->data+css+4))+sofar);
+ ldl_be_p(tp->data+css+4)+sofar);
if (tp->paylen - sofar > tp->mss)
tp->data[css + 13] &= ~9; // PSH, FIN
} else // UDP
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index ac5b2e0..9524931 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -412,11 +412,6 @@ static inline void stfq_be_p(void *ptr, float64 v)
/* Legacy unaligned versions. Note that we never had a complete set. */
-static inline uint32_t be32_to_cpupu(const uint32_t *p)
-{
- return ldl_be_p(p);
-}
-
static inline void cpu_to_be16wu(uint16_t *p, uint16_t v)
{
stw_be_p(p, v);
--
1.7.9.5
next prev parent reply other threads:[~2013-08-25 14:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-25 14:59 [Qemu-devel] [PATCH 0/9] Remove legacy unaligned bswap functions Peter Maydell
2013-08-25 14:59 ` [Qemu-devel] [PATCH 1/9] bswap.h: Remove cpu_to_le16wu() Peter Maydell
2013-08-25 14:59 ` [Qemu-devel] [PATCH 2/9] bswap.h: Remove cpu_to_le32wu() Peter Maydell
2013-08-26 9:02 ` Stefan Hajnoczi
2013-08-25 14:59 ` [Qemu-devel] [PATCH 3/9] bswap.h: Remove le16_to_cpupu() Peter Maydell
2013-08-25 14:59 ` [Qemu-devel] [PATCH 4/9] bswap.h: Remove le32_to_cpupu() Peter Maydell
2013-08-26 9:04 ` Stefan Hajnoczi
2013-08-25 14:59 ` Peter Maydell [this message]
2013-08-26 9:05 ` [Qemu-devel] [PATCH 5/9] bswap.h: Remove be32_to_cpupu() Stefan Hajnoczi
2013-08-25 14:59 ` [Qemu-devel] [PATCH 6/9] bswap.h: Remove cpu_to_be16wu() Peter Maydell
2013-08-26 9:07 ` Stefan Hajnoczi
2013-08-25 14:59 ` [Qemu-devel] [PATCH 7/9] bswap.h: Remove cpu_to_be32wu() Peter Maydell
2013-08-26 9:08 ` Stefan Hajnoczi
2013-08-25 14:59 ` [Qemu-devel] [PATCH 8/9] bswap.h: Remove cpu_to_be64wu() Peter Maydell
2013-08-26 9:09 ` Stefan Hajnoczi
2013-08-25 14:59 ` [Qemu-devel] [PATCH 9/9] bswap.h: Remove cpu_to_32wu() Peter Maydell
2013-08-26 14:06 ` [Qemu-devel] [PATCH 0/9] Remove legacy unaligned bswap functions Richard Henderson
2013-09-09 10:38 ` Peter Maydell
2013-10-15 13:36 ` Peter Maydell
2013-10-16 19:09 ` Michael S. Tsirkin
2013-09-09 11:54 ` Michael S. Tsirkin
2013-09-09 12:17 ` Peter Maydell
2013-10-15 14:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377442777-11066-6-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).