From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1VDqCr-0006VB-9G
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 02:23:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1VDqCl-0006Ud-9v
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 02:23:17 -0400
Message-ID: <1377498171.3819.37.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 26 Aug 2013 16:22:51 +1000
In-Reply-To: <F763F221-7BA8-4003-A2F9-7CBB822A519A@suse.de>
References: <1377249737-12570-1-git-send-email-aik@ozlabs.ru>
	<24C2B209-2082-4AF8-A8FB-1FF8A8B7751B@suse.de>
	<1377468637.3819.27.camel@pasglop> <87vc2tysur.fsf@linux.vnet.ibm.com>
	<F763F221-7BA8-4003-A2F9-7CBB822A519A@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>

On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote:
> > +    cap.flags = 0;
> > +    cap.migration.ecl = 0;
> > +    cap.reserve.type = 0;
> > +    cap.migration.common.server_support = 0;
> > +    cap.reserve.common.server_support = 0;
> 
> My question stands unanswered. Is this just memset(0)?

If it is, then why bother reading it in the first place ? :-)

Note that even if it is, I'd rather keep it that way as we are
eventually going to populate some stuff and so we have just the
placeholders to do it.

Cheers,
Ben.