From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDtef-0005Zu-Lv for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:04:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDteZ-0007CA-OG for qemu-devel@nongnu.org; Mon, 26 Aug 2013 06:04:13 -0400 Message-ID: <1377511424.3819.51.camel@pasglop> From: Benjamin Herrenschmidt Date: Mon, 26 Aug 2013 20:03:44 +1000 In-Reply-To: <9B59EB2A-3DB8-499F-9C94-7CB03704E429@suse.de> References: <1377249737-12570-1-git-send-email-aik@ozlabs.ru> <24C2B209-2082-4AF8-A8FB-1FF8A8B7751B@suse.de> <1377468637.3819.27.camel@pasglop> <87vc2tysur.fsf@linux.vnet.ibm.com> <1377498171.3819.37.camel@pasglop> <9B59EB2A-3DB8-499F-9C94-7CB03704E429@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Alexey Kardashevskiy , Paolo Bonzini , "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" , Nikunj A Dadhania On Mon, 2013-08-26 at 10:43 +0200, Alexander Graf wrote: > Do we ever need to preserve random fields in that struct? Or would it > be clearer to just set the whole thing to 0 and then go from there? Yeah sort of, we set/clear bits more/less based on what the guest put in the first place, it's a bit strange. > It's definitely a case-by-case decision which way is better, but > setting all fields by hand gives you potential for missing to set one. Right. I'll let Nikunj judge here as he looked at that part of the protocol more than I have. Cheers, Ben.