From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: anthony@codemonkey.ws, aurelien@aurel32.net
Subject: [Qemu-devel] [PULL 1/7] tcg: Tidy generated code for tcg_outN
Date: Mon, 26 Aug 2013 14:00:06 -0700 [thread overview]
Message-ID: <1377550812-908-2-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1377550812-908-1-git-send-email-rth@twiddle.net>
Aliasing was forcing s->code_ptr to be re-read after the store.
Keep the pointer in a local variable to help the compiler.
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/tcg.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index dac8224..42c95af 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -121,14 +121,16 @@ static inline void tcg_out8(TCGContext *s, uint8_t v)
static inline void tcg_out16(TCGContext *s, uint16_t v)
{
- *(uint16_t *)s->code_ptr = v;
- s->code_ptr += 2;
+ uint8_t *p = s->code_ptr;
+ *(uint16_t *)p = v;
+ s->code_ptr = p + 2;
}
static inline void tcg_out32(TCGContext *s, uint32_t v)
{
- *(uint32_t *)s->code_ptr = v;
- s->code_ptr += 4;
+ uint8_t *p = s->code_ptr;
+ *(uint32_t *)p = v;
+ s->code_ptr = p + 4;
}
/* label relocation processing */
--
1.8.1.4
next prev parent reply other threads:[~2013-08-26 21:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 21:00 [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization Richard Henderson
2013-08-26 21:00 ` Richard Henderson [this message]
2013-08-26 21:00 ` [Qemu-devel] [PULL 2/7] tcg-i386: Add and use tcg_out64 Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 3/7] tcg-i386: Try pc-relative lea for constant formation Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 4/7] tcg-i386: Tidy qemu_ld/st slow path Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument Richard Henderson
2013-08-26 22:26 ` Paolo Bonzini
2013-08-26 22:34 ` Richard Henderson
2013-08-27 10:46 ` Aurelien Jarno
2013-08-27 14:53 ` Richard Henderson
2013-08-27 15:43 ` Aurelien Jarno
2013-08-27 15:53 ` Richard Henderson
2013-08-26 23:26 ` Peter Maydell
2013-08-27 10:47 ` Aurelien Jarno
2013-08-26 21:00 ` [Qemu-devel] [PULL 6/7] tcg: Tidy softmmu_template.h Richard Henderson
2013-08-26 21:00 ` [Qemu-devel] [PULL 7/7] tcg-i386: Use new return-argument ld/st helpers Richard Henderson
2013-08-28 22:55 ` Richard W.M. Jones
2013-08-29 15:21 ` [Qemu-devel] [PATCH] tcg-i386: Remove abort from GETPC_LDST Richard Henderson
2013-08-29 15:28 ` Paolo Bonzini
2013-08-29 15:32 ` Richard Henderson
2013-08-29 15:50 ` Richard W.M. Jones
2013-08-29 19:13 ` Aurelien Jarno
2013-08-27 21:30 ` [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377550812-908-2-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).