From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities
Date: Tue, 27 Aug 2013 10:45:15 +1000 [thread overview]
Message-ID: <1377564315.3819.88.camel@pasglop> (raw)
In-Reply-To: <521B5A0C.2050409@redhat.com>
On Mon, 2013-08-26 at 15:37 +0200, Paolo Bonzini wrote:
> There are certainly cases where time-of-check-to-time-of-use
> vulnerability could make QEMU access uninitialized memory (or worse,
> out-of-bounds arrays). For example, you could try racing the host on
> the length of a scatter/gather list.
Sure, and I mentioned that too, the latest patch from Nikunj addresses
it, I still think however that it's not a good practice to copy
everything, then do the byteswaps on the result (and it defeats use of
sparse for endian checking if we ever want to do that).
Ben.
next prev parent reply other threads:[~2013-08-27 0:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:22 [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities Alexey Kardashevskiy
2013-08-25 16:41 ` Alexander Graf
2013-08-25 20:51 ` Benjamin Herrenschmidt
2013-08-26 13:37 ` Paolo Bonzini
2013-08-27 0:45 ` Benjamin Herrenschmidt [this message]
2013-08-25 22:10 ` Benjamin Herrenschmidt
2013-08-26 4:32 ` Nikunj A Dadhania
2013-08-26 5:44 ` Alexander Graf
2013-08-26 6:22 ` Benjamin Herrenschmidt
2013-08-26 8:43 ` Alexander Graf
2013-08-26 9:08 ` Nikunj A Dadhania
2013-08-26 9:52 ` Alexander Graf
2013-08-26 10:03 ` Benjamin Herrenschmidt
2013-08-26 10:47 ` Nikunj A Dadhania
2013-08-26 10:58 ` Nikunj A Dadhania
2013-08-26 11:17 ` Alexander Graf
2013-08-26 11:46 ` Nikunj A Dadhania
2013-08-26 11:49 ` Alexander Graf
2013-08-27 5:14 ` Nikunj A Dadhania
2013-08-27 5:43 ` Nikunj A Dadhania
2013-08-27 8:45 ` Alexander Graf
2013-08-27 9:27 ` Nikunj A Dadhania
2013-08-26 6:19 ` Benjamin Herrenschmidt
2013-08-26 9:06 ` Nikunj A Dadhania
2013-08-26 13:42 ` Paolo Bonzini
2013-08-27 5:11 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377564315.3819.88.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).