qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com,
	Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
	stefanha@redhat.com
Subject: [Qemu-devel] [RFC PATCH 2/3] block: add function qemu_get_bds_queue
Date: Tue, 27 Aug 2013 15:49:24 +0800	[thread overview]
Message-ID: <1377589765-30215-3-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1377589765-30215-1-git-send-email-xiawenc@linux.vnet.ibm.com>

It should be caller's responsibility to tell which bds* needs take
action in multithread case, but since now only one thread exist
and only one bds* group exist, add this function to manage the
bds* queue temporarily. Once the block layer user code manage
the bds* queue by itself and global bdrv_states is moved out,
this function can be removed.

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 block.c               |    5 +++++
 include/block/block.h |    3 +++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/block.c b/block.c
index 9db3c32..bf35b90 100644
--- a/block.c
+++ b/block.c
@@ -102,6 +102,11 @@ static QLIST_HEAD(, BlockDriver) bdrv_drivers =
 /* If non-zero, use only whitelisted block drivers */
 static int use_bdrv_whitelist;
 
+BlockDrvierStateQueue *qemu_get_bds_queue(void)
+{
+    return &bdrv_states;
+}
+
 #ifdef _WIN32
 static int is_windows_drive_prefix(const char *filename)
 {
diff --git a/include/block/block.h b/include/block/block.h
index b0d4f2b..323a732 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -95,6 +95,9 @@ typedef struct BDRVReopenState {
     void *opaque;
 } BDRVReopenState;
 
+/* This function could be removed when block layer is thread safe. Then let
+   caller manage the bds it used, instead of block layer. */
+BlockDrvierStateQueue *qemu_get_bds_queue(void);
 
 void bdrv_iostatus_enable(BlockDriverState *bs);
 void bdrv_iostatus_reset(BlockDriverState *bs);
-- 
1.7.1

  parent reply	other threads:[~2013-08-27  7:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  7:49 [Qemu-devel] [RFC PATCH 0/3] move global bdrv_states out of block.c Wenchao Xia
2013-08-27  7:49 ` [Qemu-devel] [RFC PATCH 1/3] block: add typedef for BlockDriverState queue Wenchao Xia
2013-08-27  7:49 ` Wenchao Xia [this message]
2013-08-27  7:49 ` [Qemu-devel] [RFC PATCH 3/3] block: add parameter bds queue in bdrv_invalidate_cache_all() Wenchao Xia
2013-09-18 14:03 ` [Qemu-devel] [RFC PATCH 0/3] move global bdrv_states out of block.c Stefan Hajnoczi
2013-09-20  6:24   ` Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377589765-30215-3-git-send-email-xiawenc@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).