From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEEZV-0006c6-Qt for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:24:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEEZP-0004Rv-S3 for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:24:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEEZP-0004Rn-Kp for qemu-devel@nongnu.org; Tue, 27 Aug 2013 04:24:11 -0400 From: Stefan Hajnoczi Date: Tue, 27 Aug 2013 10:23:58 +0200 Message-Id: <1377591839-2743-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1377591839-2743-1-git-send-email-stefanha@redhat.com> References: <1377591839-2743-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/2] qemu-timer: drop outdated signal safety comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Ping Fan Liu , Stefan Hajnoczi , Alex Bligh host_alarm_handler() is invoked from the signal processing thread (currently the iothread). Previously we did processing in a real signal handler with signalfd and therefore needed signal-safe timer code. Today host_alarm_handler() just marks the alarm timer as expired/pending and notifies the main loop using qemu_notify_event(). Therefore these outdated comments about signal safety can be dropped. Signed-off-by: Stefan Hajnoczi --- qemu-timer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 95ff47f..ed3fcb2 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -301,8 +301,6 @@ void timer_del(QEMUTimer *ts) { QEMUTimer **pt, *t; - /* NOTE: this code must be signal safe because - timer_expired() can be called from a signal. */ pt = &ts->timer_list->active_timers; for(;;) { t = *pt; @@ -325,8 +323,6 @@ void timer_mod_ns(QEMUTimer *ts, int64_t expire_time) timer_del(ts); /* add the timer in the sorted list */ - /* NOTE: this code must be signal safe because - timer_expired() can be called from a signal. */ pt = &ts->timer_list->active_timers; for(;;) { t = *pt; -- 1.8.3.1