From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org,
Alex Williamson <alex.williamson@redhat.com>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] kvm irqfd: support msimessage to irq translation in PHB
Date: Tue, 27 Aug 2013 20:32:28 +1000 [thread overview]
Message-ID: <1377599548.3819.133.camel@pasglop> (raw)
In-Reply-To: <20130827102647.GA24655@redhat.com>
On Tue, 2013-08-27 at 13:26 +0300, Michael S. Tsirkin wrote:
> e would end up with something like
> >
> > diff --git a/kvm-all.c b/kvm-all.c
> > index 716860f..ca3251e 100644
> > --- a/kvm-all.c
> > +++ b/kvm-all.c
> > @@ -1190,6 +1190,10 @@ int kvm_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
> > struct kvm_irq_routing_entry kroute = {};
> > int virq;
> >
> > + if (kvm_gsi_routing_linear()) {
> > + return msi.data & 0xffff;
> > + }
> > +
I haven't followed the whole discussion, Alexey, is this the per-host
bridge source number or the global XIRR (XICS interrupt number) ?
Because in the latter case, it can be up to 24 bits... (And yes, MSI
data is limited to 16).
However maybe we can decide arbitrarily that under qemu/kvm we only
support 16-bit XIRRs (it's fine, from a PAPR perspective at least if it
keep things simpler).
Cheers,
Ben.
next prev parent reply other threads:[~2013-08-27 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 8:51 [Qemu-devel] [PATCH 0/2 v4] kvm irqfd: support msimessage to irq translation in PHB Alexey Kardashevskiy
2013-08-07 8:51 ` [Qemu-devel] [PATCH 1/2] " Alexey Kardashevskiy
2013-08-19 7:35 ` Michael S. Tsirkin
2013-08-19 7:44 ` Alexey Kardashevskiy
2013-08-19 7:54 ` Michael S. Tsirkin
2013-08-19 8:10 ` Alexey Kardashevskiy
2013-08-19 9:01 ` Michael S. Tsirkin
2013-08-23 4:29 ` Alexey Kardashevskiy
2013-08-27 10:06 ` Alexander Graf
2013-08-27 10:26 ` Michael S. Tsirkin
2013-08-27 10:32 ` Benjamin Herrenschmidt [this message]
2013-08-27 11:31 ` Alexander Graf
2013-08-28 0:55 ` Alexey Kardashevskiy
2013-08-07 8:51 ` [Qemu-devel] [PATCH 2/2] pseries: enable irqfd for pci Alexey Kardashevskiy
2013-08-19 5:15 ` [Qemu-devel] [PATCH 0/2 v4] kvm irqfd: support msimessage to irq translation in PHB Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377599548.3819.133.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).