From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-stable@nongnu.org, qemu list <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()
Date: Wed, 28 Aug 2013 09:09:47 +0200 [thread overview]
Message-ID: <1377673787.20403.16.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <f1a7d37fcd2b6fb21d4f536628aad0cd67521ff5.1377666450.git.amit.shah@redhat.com>
Hi,
> +static void tcp_chr_detach(CharDriverState *chr)
> +{
> + TCPCharDriver *s = chr->opaque;
> +
> + if (s->tag) {
> + io_remove_watch_poll(s->tag);
> + s->tag = 0;
> + }
> +}
Lots of simliar functions in the other patches.
Doesn't it make sense to move the tag field from TCPCharDriver to
CharDriverState instead, so we don't need a new callback in the first
place?
cheers,
Gerd
next prev parent reply other threads:[~2013-08-28 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 5:10 [Qemu-devel] [PATCH 0/9] char: fix segfault on chardev detach Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 1/9] char: remove watch callback on chardev detach from frontend Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach() Amit Shah
2013-08-28 7:09 ` Gerd Hoffmann [this message]
2013-08-28 8:10 ` Amit Shah
2013-08-28 11:38 ` Gerd Hoffmann
2013-08-28 5:10 ` [Qemu-devel] [PATCH 3/9] char: introduce fd_chr_detach() Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 4/9] char: introduce pty_chr_detach() Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 5/9] char: introduce udp_chr_detach() Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 6/9] char: use the new fd_chr_detach to dedup code Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 7/9] char: use the new pty_chr_detach " Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 8/9] char: use the new udp_chr_detach " Amit Shah
2013-08-28 5:10 ` [Qemu-devel] [PATCH 9/9] char: use the new tcp_chr_detach " Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377673787.20403.16.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=hdegoede@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).