From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEaq7-0003l7-Lc for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEaq1-0003ia-KQ for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:10:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEaq1-0003iR-7W for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:10:49 -0400 Message-ID: <1377677448.6332.5.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Wed, 28 Aug 2013 11:10:48 +0300 In-Reply-To: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> References: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, aliguori@us.ibm.com, mst@redhat.com, armbru@redhat.com, afaerber@suse.de On Thu, 2013-08-22 at 15:48 +0300, Marcel Apfelbaum wrote: > This patch follows Markus Armbruster suggestion: > > A possibly better way to group help by category: instead of adding > categories to each line, add category headlines, like this: > > Controller/Bridge/Hub devices: > name "NAME", bus "BUS"... > ... > USB devices: > name "NAME", bus "BUS"... > ... > Storage devices: > ... > > This way, showing devices with multiple categories once per category > actually makes sense. > > Note that the "categories to each line" is kept for 2 reasons: > 1. Preparation for multifunction devices > 2. Ability to grep by category ping Marcel > > Signed-off-by: Marcel Apfelbaum > --- > qdev-monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/qdev-monitor.c b/qdev-monitor.c > index 410cdcb..a7329b0 100644 > --- a/qdev-monitor.c > +++ b/qdev-monitor.c > @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory category) > DeviceClass *dc; > GSList *list, *curr; > > + error_printf("%s devices:\n", qdev_category_get_name(category)); > + > list = object_class_get_list(TYPE_DEVICE, false); > for (curr = list; curr; curr = g_slist_next(curr)) { > dc = (DeviceClass *)object_class_dynamic_cast(curr->data, TYPE_DEVICE);